Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/376428 )

Change subject: Add kafka rack (row) awareness configs
......................................................................


Add kafka rack (row) awareness configs

Bug: T167992
Change-Id: Ie90aa97d8b5f456b343de7ff5400aac917d63823
---
M hieradata/common.yaml
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved



diff --git a/hieradata/common.yaml b/hieradata/common.yaml
index a415be3..801e8ee 100644
--- a/hieradata/common.yaml
+++ b/hieradata/common.yaml
@@ -469,22 +469,31 @@
       kafka2003.codfw.wmnet:
         id: 2003
 
-  # TODO: Add rack/row comments once these are racked.
+  # NOTE:  The 'rack' here is used by the confluent kafka module
+  # to assign broker.rack for Kafka rack awareness.  We are actually setting
+  # the row letter, not the full row-rack number, since each of these brokers
+  # are in different racks anyway.  We do awareness at the row level.
   jumbo-eqiad:
     zookeeper_cluster_name: main-eqiad
     brokers:
       kafka-jumbo1001.eqiad.wmnet:
         id: 1001
+        rack: A
       kafka-jumbo1002.eqiad.wmnet:
         id: 1002
+        rack: A
       kafka-jumbo1003.eqiad.wmnet:
         id: 1003
+        rack: B
       kafka-jumbo1004.eqiad.wmnet:
         id: 1004
+        rack: C
       kafka-jumbo1005.eqiad.wmnet:
         id: 1005
+        rack: C
       kafka-jumbo1006.eqiad.wmnet:
         id: 1006
+        rack: D
 
 deployment_server: tin.eqiad.wmnet
 

-- 
To view, visit https://gerrit.wikimedia.org/r/376428
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie90aa97d8b5f456b343de7ff5400aac917d63823
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <ao...@wikimedia.org>
Gerrit-Reviewer: Ottomata <ao...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to