jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/376644 )
Change subject: Fix interpretation of 'prioritized'
......................................................................
Fix interpretation of 'prioritized'
Docs (especially in EventPresentationModel.php) say true means outside
the menu, false inside.
However, it was interpreting any non-undefined value as true.
Change-Id: Icb438538e5c588c1ac7d4bbac0b762dd07057199
---
M modules/ui/mw.echo.ui.NotificationItemWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
Objections:
Mattflaschen: There's a problem with this change, please improve
diff --git a/modules/ui/mw.echo.ui.NotificationItemWidget.js
b/modules/ui/mw.echo.ui.NotificationItemWidget.js
index 475b695..9dbebae 100644
--- a/modules/ui/mw.echo.ui.NotificationItemWidget.js
+++ b/modules/ui/mw.echo.ui.NotificationItemWidget.js
@@ -130,7 +130,7 @@
// prioritized explicitly, *except* for items inside a
bundle
// (where all actions are inside the menu) or there are
more than
// two prioritized actions (all others go into the menu)
- isOutsideMenu = !this.bundle && urlObj.prioritized !==
undefined && outsideMenuItemCounter < mw.echo.config.maxPrioritizedActions;
+ isOutsideMenu = !this.bundle && urlObj.prioritized &&
outsideMenuItemCounter < mw.echo.config.maxPrioritizedActions;
linkButton = new mw.echo.ui.MenuItemWidget( {
type: urlObj.type,
--
To view, visit https://gerrit.wikimedia.org/r/376644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb438538e5c588c1ac7d4bbac0b762dd07057199
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
