Divec has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377510 )
Change subject: ve.ce.BranchNode#splice: disconnect nodes fully
......................................................................
ve.ce.BranchNode#splice: disconnect nodes fully
Change-Id: If2c549d4fefe3f5b18a5274b7b49d64eddc617b9
---
M src/ce/ve.ce.BranchNode.js
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/10/377510/1
diff --git a/src/ce/ve.ce.BranchNode.js b/src/ce/ve.ce.BranchNode.js
index 5b33564..6008b05 100644
--- a/src/ce/ve.ce.BranchNode.js
+++ b/src/ce/ve.ce.BranchNode.js
@@ -198,6 +198,7 @@
removals = this.children.splice.apply( this.children, args );
for ( i = 0, length = removals.length; i < length; i++ ) {
removals[ i ].model.disconnect( this, { update: 'onModelUpdate'
} );
+ removals[ i ].model.disconnect( removals[ i ] );
removals[ i ].setLive( false );
removals[ i ].detach();
removals[ i ].$element.detach();
--
To view, visit https://gerrit.wikimedia.org/r/377510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2c549d4fefe3f5b18a5274b7b49d64eddc617b9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <da...@troi.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
