jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/376275 )
Change subject: Use new ThumbnailImage params
......................................................................
Use new ThumbnailImage params
ThumbnailImage::__construct signature has changed,
and while it still accepts params in the old order/format,
we should call it the right way.
There is another call elsewhere in this file that already
passes in the correct (new) params - another good reason
to be consistent.
Change-Id: I78e96d81c9d73aaf7e304afbf3db55ac0a2474b0
---
M ThreeDHandler.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
MarkTraceur: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ThreeDHandler.php b/ThreeDHandler.php
index 2e02080..02145ad 100644
--- a/ThreeDHandler.php
+++ b/ThreeDHandler.php
@@ -115,7 +115,7 @@
wfHostname(), $retval, trim( $err ), $cmd ) );
return new \MediaTransformError( 'thumbnail_error',
$width, $height, $err );
} else {
- return new \ThumbnailImage( $image, $dstUrl, $width,
$height, $dstPath );
+ return new \ThumbnailImage( $image, $dstUrl, $dstPath,
$params );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/376275
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78e96d81c9d73aaf7e304afbf3db55ac0a2474b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/3D
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: MarkTraceur <mholmqu...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
