VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378361 )
Change subject: Make `box-sizing: border-box` the default on wigets
......................................................................
Make `box-sizing: border-box` the default on wigets
Setting `box-sizing: border-box` as default on all widgets and
clean up with the insane mish-mash in the library.
Bug: T147692
Change-Id: I12b6431f9c3430e992f60f61429eb9f9bb3ac228
---
M src/styles/Widget.less
M src/styles/widgets/DropdownInputWidget.less
M src/styles/widgets/ProgressBarWidget.less
M src/styles/widgets/TabOptionWidget.less
M src/styles/widgets/TextInputWidget.less
M src/styles/widgets/ToggleSwitchWidget.less
M src/themes/apex/widgets.less
M src/themes/wikimediaui/widgets.less
8 files changed, 2 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/61/378361/1
diff --git a/src/styles/Widget.less b/src/styles/Widget.less
index 107bc42..8d8f1f3 100644
--- a/src/styles/Widget.less
+++ b/src/styles/Widget.less
@@ -1,5 +1,7 @@
@import 'common';
.oo-ui-widget {
+ .oo-ui-box-sizing( border-box );
+
.theme-oo-ui-widget();
}
diff --git a/src/styles/widgets/DropdownInputWidget.less
b/src/styles/widgets/DropdownInputWidget.less
index 72037df..02405f8 100644
--- a/src/styles/widgets/DropdownInputWidget.less
+++ b/src/styles/widgets/DropdownInputWidget.less
@@ -4,7 +4,6 @@
position: relative;
// Necessary for proper alignment when used with `display: inline-block`
vertical-align: middle;
- .oo-ui-box-sizing( border-box );
.oo-ui-dropdownWidget,
select {
diff --git a/src/styles/widgets/ProgressBarWidget.less
b/src/styles/widgets/ProgressBarWidget.less
index 6231368..82993fc 100644
--- a/src/styles/widgets/ProgressBarWidget.less
+++ b/src/styles/widgets/ProgressBarWidget.less
@@ -1,7 +1,5 @@
@import '../common';
.oo-ui-progressBarWidget {
- .oo-ui-box-sizing( border-box );
-
.theme-oo-ui-progressBarWidget();
}
diff --git a/src/styles/widgets/TabOptionWidget.less
b/src/styles/widgets/TabOptionWidget.less
index fdc3bf0..0b83154 100644
--- a/src/styles/widgets/TabOptionWidget.less
+++ b/src/styles/widgets/TabOptionWidget.less
@@ -2,7 +2,6 @@
.oo-ui-tabOptionWidget {
display: inline-block;
- .oo-ui-box-sizing( border-box );
vertical-align: bottom;
.theme-oo-ui-tabOptionWidget();
diff --git a/src/styles/widgets/TextInputWidget.less
b/src/styles/widgets/TextInputWidget.less
index 1b60524..1164e8c 100644
--- a/src/styles/widgets/TextInputWidget.less
+++ b/src/styles/widgets/TextInputWidget.less
@@ -4,7 +4,6 @@
position: relative;
// Necessary for proper alignment when used with `display: inline-block`
vertical-align: middle;
- .oo-ui-box-sizing( border-box );
input,
textarea {
diff --git a/src/styles/widgets/ToggleSwitchWidget.less
b/src/styles/widgets/ToggleSwitchWidget.less
index 6c8a36d..6b1a169 100644
--- a/src/styles/widgets/ToggleSwitchWidget.less
+++ b/src/styles/widgets/ToggleSwitchWidget.less
@@ -5,7 +5,6 @@
display: inline-block;
vertical-align: middle;
overflow: hidden;
- .oo-ui-box-sizing( border-box );
.oo-ui-force-gpu-composite-layer();
&.oo-ui-widget-enabled {
diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index ea8f67a..e63bbde 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -171,7 +171,6 @@
.theme-oo-ui-capsuleItemWidget () {
width: auto;
max-width: 100%;
- .oo-ui-box-sizing( border-box );
vertical-align: middle;
padding: 0 0.4em;
margin: 0.1em;
@@ -1108,7 +1107,6 @@
.theme-oo-ui-tagItemWidget () {
width: auto;
max-width: 100%;
- .oo-ui-box-sizing( border-box );
vertical-align: middle;
padding: 0 0.4em;
margin: 0.1em;
diff --git a/src/themes/wikimediaui/widgets.less
b/src/themes/wikimediaui/widgets.less
index 4a9bed7..d7e956b 100644
--- a/src/themes/wikimediaui/widgets.less
+++ b/src/themes/wikimediaui/widgets.less
@@ -152,7 +152,6 @@
}
.theme-oo-ui-capsuleItemWidget () {
- .oo-ui-box-sizing( border-box );
width: auto;
max-width: 100%;
height: @height-tagitem;
@@ -672,7 +671,6 @@
// Remove user agent styles
-webkit-appearance: none;
-moz-appearance: none;
- .oo-ui-box-sizing( border-box );
border: @border-base;
border-radius: @border-radius-base;
padding: @padding-base;
@@ -1558,7 +1556,6 @@
}
.theme-oo-ui-tagItemWidget () {
- .oo-ui-box-sizing( border-box );
width: auto;
max-width: 100%;
height: @height-tagitem;
--
To view, visit https://gerrit.wikimedia.org/r/378361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12b6431f9c3430e992f60f61429eb9f9bb3ac228
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
