jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378721 )
Change subject: Better JSON wellformedness check AddFormRequestParser
......................................................................
Better JSON wellformedness check AddFormRequestParser
Change-Id: Iff4f91b7ffd27d6cb705c54d9b42386b7db75e6e
---
M src/Api/AddFormRequestParser.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Aleksey Bekh-Ivanov (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/Api/AddFormRequestParser.php b/src/Api/AddFormRequestParser.php
index bb2a7aa..f19f64a 100644
--- a/src/Api/AddFormRequestParser.php
+++ b/src/Api/AddFormRequestParser.php
@@ -33,7 +33,7 @@
}
$data = json_decode( $params['data'], true );
- if ( $data === null ) {
+ if ( json_last_error() !== JSON_ERROR_NONE ) {
return AddFormRequestParserResult::newWithErrors( [
'data-invalid-json' ] );
}
--
To view, visit https://gerrit.wikimedia.org/r/378721
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff4f91b7ffd27d6cb705c54d9b42386b7db75e6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <aleksey.bekh-iva...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
