Huji has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378752 )
Change subject: Assert that blocks were inserted successfully in UserTest
......................................................................
Assert that blocks were inserted successfully in UserTest
Bug: T176103
Change-Id: Ia8afc37605a844590abe49eaad1e806bd2c7f6f8
---
M tests/phpunit/includes/user/UserTest.php
1 file changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/52/378752/1
diff --git a/tests/phpunit/includes/user/UserTest.php
b/tests/phpunit/includes/user/UserTest.php
index aa368de..a7d8f38 100644
--- a/tests/phpunit/includes/user/UserTest.php
+++ b/tests/phpunit/includes/user/UserTest.php
@@ -610,7 +610,8 @@
'expiry' => wfTimestamp( TS_MW, $expiryFiveHours ),
] );
$block->setTarget( $user1tmp );
- $block->insert();
+ $res = $block->insert();
+ $this->assertTrue( (bool)$res['id'], 'Block succeeded' );
$user1 = User::newFromSession( $request1 );
$user1->mBlock = $block;
$user1->load();
@@ -678,7 +679,8 @@
$request1->getSession()->setUser( $testUser );
$block = new Block( [ 'enableAutoblock' => true ] );
$block->setTarget( $testUser );
- $block->insert();
+ $res = $block->insert();
+ $this->assertTrue( (bool)$res['id'], 'Block succeeded' );
$user = User::newFromSession( $request1 );
$user->mBlock = $block;
$user->load();
@@ -714,7 +716,8 @@
$request1->getSession()->setUser( $user1Tmp );
$block = new Block( [ 'enableAutoblock' => true, 'expiry' =>
'infinity' ] );
$block->setTarget( $user1Tmp );
- $block->insert();
+ $res = $block->insert();
+ $this->assertTrue( (bool)$res['id'], 'Block succeeded' );
$user1 = User::newFromSession( $request1 );
$user1->mBlock = $block;
$user1->load();
@@ -801,7 +804,8 @@
$request1->getSession()->setUser( $user1tmp );
$block = new Block( [ 'enableAutoblock' => true ] );
$block->setTarget( $user1tmp );
- $block->insert();
+ $res = $block->insert();
+ $this->assertTrue( (bool)$res['id'], 'Block succeeded' );
$user1 = User::newFromSession( $request1 );
$user1->mBlock = $block;
$user1->load();
@@ -838,7 +842,8 @@
$request1->getSession()->setUser( $user1tmp );
$block = new Block( [ 'enableAutoblock' => true ] );
$block->setTarget( $user1tmp );
- $block->insert();
+ $res = $block->insert();
+ $this->assertTrue( (bool)$res['id'], 'Block succeeded' );
$user1 = User::newFromSession( $request1 );
$user1->mBlock = $block;
$user1->load();
--
To view, visit https://gerrit.wikimedia.org/r/378752
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8afc37605a844590abe49eaad1e806bd2c7f6f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Huji <huji.h...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
