Sbisson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/378767 )

Change subject: WLFilter: always create a balanced fieldset
......................................................................

WLFilter: always create a balanced fieldset

Don't count on Xml::fieldset creating only the opening tag.

Bug: T176155
Change-Id: Idc4e450c9fa03fc78a012fb5eefa60174bb1245a
---
M includes/specials/SpecialWatchlist.php
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/67/378767/1

diff --git a/includes/specials/SpecialWatchlist.php 
b/includes/specials/SpecialWatchlist.php
index 2750551..8418865 100644
--- a/includes/specials/SpecialWatchlist.php
+++ b/includes/specials/SpecialWatchlist.php
@@ -635,11 +635,13 @@
                        'id' => 'mw-watchlist-form'
                ] );
                $form .= Html::hidden( 'title', 
$this->getPageTitle()->getPrefixedText() );
-               $form .= Xml::fieldset(
-                       $this->msg( 'watchlist-options' )->text(),
-                       false,
+               $form .= Xml::openElement(
+                       'fieldset',
                        [ 'id' => 'mw-watchlist-options', 'class' => 
'cloptions' ]
                );
+               $form .= Xml::element(
+                       'legend', null, $this->msg( 'watchlist-options' 
)->text()
+               );
 
                if ( !$this->isStructuredFilterUiEnabled() ) {
                        $form .= $this->makeLegend();

-- 
To view, visit https://gerrit.wikimedia.org/r/378767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc4e450c9fa03fc78a012fb5eefa60174bb1245a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Sbisson <sbis...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to