jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378773 )
Change subject: Follow-up 4107d1d4: avoid JS errors when trying to call
mw.track() from jquery.migrate
......................................................................
Follow-up 4107d1d4: avoid JS errors when trying to call mw.track() from
jquery.migrate
Some migrateWarn() calls (like the one for compatMode) happen before
mw is created. Don't crash on trying to call mw.track() in that case.
Change-Id: I9e33af2865bb10adc0473045f714fe4f9f699861
---
M resources/lib/jquery/jquery.migrate.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/lib/jquery/jquery.migrate.js
b/resources/lib/jquery/jquery.migrate.js
index 12212ff..70512e0 100644
--- a/resources/lib/jquery/jquery.migrate.js
+++ b/resources/lib/jquery/jquery.migrate.js
@@ -83,7 +83,9 @@
warnedAbout[ msg ] = true;
jQuery.migrateWarnings.push( msg );
// PATCH: Add instrumentation for statistics --Krinkle
- mw.track( "mw.deprecate", "jquery-migrate" );
+ if ( window.mw && window.mw.track ) {
+ window.mw.track( "mw.deprecate", "jquery-migrate" );
+ }
if ( console && console.warn && !jQuery.migrateMute ) {
console.warn( "JQMIGRATE: " + msg );
if ( jQuery.migrateTrace && console.trace ) {
--
To view, visit https://gerrit.wikimedia.org/r/378773
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e33af2865bb10adc0473045f714fe4f9f699861
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
