Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/378805 )

Change subject: Add support for draftquality models
......................................................................

Add support for draftquality models

Bug: T176183
Change-Id: Ic64a020025a25e3079b1fd58c0c7d51611eae928
---
M extension.json
M includes/FetchScoreJob.php
M includes/Hooks.php
3 files changed, 22 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES 
refs/changes/05/378805/1

diff --git a/extension.json b/extension.json
index f7e857b..5abb940 100644
--- a/extension.json
+++ b/extension.json
@@ -130,7 +130,8 @@
                        "damaging": true,
                        "goodfaith": true,
                        "reverted": true,
-                       "wp10": true
+                       "wp10": true,
+                       "draftquality": false
                },
                "OresModelClasses": {
                        "damaging": {
@@ -152,6 +153,12 @@
                                "GA": 3,
                                "Start": 4,
                                "Stub": 5
+                       },
+                       "draftquality": {
+                               "attack": 0,
+                               "OK": 1,
+                               "spam": 2,
+                               "vandalism": 3
                        }
                },
                "OresFiltersThresholds": {
diff --git a/includes/FetchScoreJob.php b/includes/FetchScoreJob.php
index 0d2a965..f1475a3 100644
--- a/includes/FetchScoreJob.php
+++ b/includes/FetchScoreJob.php
@@ -57,7 +57,12 @@
                if ( isset( $this->params['originalRequest'] ) ) {
                        $scoring->setOriginalRequest( 
$this->params['originalRequest'] );
                }
-               $scores = $scoring->getScores( $this->params['revid'], null, 
$this->params['extra_params'] );
+               if ( isset( $this->params['models'] ) ) {
+                       $models = $this->params['models'];
+               } else {
+                       $models = null;
+               }
+               $scores = $scoring->getScores( $this->params['revid'], $models, 
$this->params['extra_params'] );
                $cache = Cache::instance();
                $success = true;
                $cache->setErrorCallback( function ( $mssg, $revision ) use ( 
&$success, $logger ) {
diff --git a/includes/Hooks.php b/includes/Hooks.php
index dc2597b..bd605c3 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -58,7 +58,7 @@
         * @param RecentChange $rc
         */
        public static function onRecentChange_save( RecentChange $rc ) {
-               global $wgOresExcludeBots, $wgOresEnabledNamespaces;
+               global $wgOresExcludeBots, $wgOresEnabledNamespaces, 
$wgOresModels;
                if ( $rc->getAttribute( 'rc_bot' ) && $wgOresExcludeBots ) {
                        return;
                }
@@ -73,7 +73,13 @@
                }
 
                $rc_type = $rc->getAttribute( 'rc_type' );
+               $models = array_keys( array_filter( $wgOresModels ) );
                if ( $rc_type === RC_EDIT || $rc_type === RC_NEW ) {
+                       // Do not store draftquality data when it's not a new 
page
+                       if ( $rc_type !== RC_NEW ) {
+                               $models = array_diff( $models, [ 'draftquality' 
] );
+                       }
+
                        $revid = $rc->getAttribute( 'rc_this_oldid' );
                        $logger = LoggerFactory::getInstance( 'ORES' );
                        $logger->debug( 'Processing edit {revid}', [
@@ -86,6 +92,7 @@
                                        'ip' => $request->getIP(),
                                        'userAgent' => $request->getHeader( 
'User-Agent' ),
                                ],
+                               'models' => $models,
                                'extra_params' => [ 'precache' => 'true' ],
                        ] );
                        JobQueueGroup::singleton()->push( $job );

-- 
To view, visit https://gerrit.wikimedia.org/r/378805
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic64a020025a25e3079b1fd58c0c7d51611eae928
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <ladsgr...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to