jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/378829 )
Change subject: updatewikiversions.py: also end file with newline, which json.dump() does not ...................................................................... updatewikiversions.py: also end file with newline, which json.dump() does not Change-Id: I4d6631dde62edb12a94b1e2fe4d099cca5cc4347 --- M scap/plugins/updatewikiversions.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Chad: Looks good to me, approved jenkins-bot: Verified diff --git a/scap/plugins/updatewikiversions.py b/scap/plugins/updatewikiversions.py index c8fa490..6d51c8d 100644 --- a/scap/plugins/updatewikiversions.py +++ b/scap/plugins/updatewikiversions.py @@ -68,6 +68,7 @@ with open(json_path, 'w') as json_out: json.dump(version_rows, json_out, ensure_ascii=False, indent=4, separators=(',', ': '), sort_keys=True) + json_out.write("\n") self.get_logger().info('Updated %s: %s inserted, %s migrated.' % (json_path, inserted, migrated)) -- To view, visit https://gerrit.wikimedia.org/r/378829 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d6631dde62edb12a94b1e2fe4d099cca5cc4347 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Chad <ch...@wikimedia.org> Gerrit-Reviewer: Chad <ch...@wikimedia.org> Gerrit-Reviewer: Urbanecm <martin.urba...@wikimedia.cz> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits