Eugene233 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378867 )
Change subject: Use CSS to set the width of cells at Special:Newsletters
......................................................................
Use CSS to set the width of cells at Special:Newsletters
Currently the width of cells on the newletter tablepage is adjusted
using code which is deprecated. This has been done alternatively by using CSS.
Bug: T175645
Change-Id: I0b45ce9ef92c0101cc2de68777d55c222354a8eb
---
M includes/specials/pagers/NewsletterTablePager.php
M modules/ext.newsletter.newsletters.styles.css
2 files changed, 26 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/67/378867/1
diff --git a/includes/specials/pagers/NewsletterTablePager.php
b/includes/specials/pagers/NewsletterTablePager.php
index 59f35f6..d623a6e 100644
--- a/includes/specials/pagers/NewsletterTablePager.php
+++ b/includes/specials/pagers/NewsletterTablePager.php
@@ -339,22 +339,6 @@
*/
public function getCellAttrs( $field, $value ) {
$ret = parent::getCellAttrs( $field, $value );
- // @todo use CSS, not inline HTML
- switch ( $field ) {
- case 'nl_name':
- $ret['width'] = '20%';
- break;
- case 'nl_desc':
- $ret['width'] = '40%';
- break;
- case 'subscriber_count':
- $ret['width'] = '5%';
- break;
- case 'action':
- $ret['width'] = '20%';
- break;
- }
-
return $ret;
}
diff --git a/modules/ext.newsletter.newsletters.styles.css
b/modules/ext.newsletter.newsletters.styles.css
index c3cd71f..09ffbb4 100644
--- a/modules/ext.newsletter.newsletters.styles.css
+++ b/modules/ext.newsletter.newsletters.styles.css
@@ -52,6 +52,32 @@
cursor: default;
}
+.mw-special-Newsletters
+.mw-datatable
+.TablePager_col_nl_name {
+ width: 20%;
+}
+
+}
+
+.mw-special-Newsletters
+.mw-datatable
+.TablePager_col_nl_desc {
+ width: 40%;
+}
+
+
+.mw-special-Newsletters
+.mw-datatable
+.TablePager_col_subscriber_count {
+ width: 5%;
+}
+
+.mw-special-Newsletters
+.mw-datatable .TablePager_col_action {
+ width: 20%;
+}
+
.mw-special-Newsletters .mw-datatable,
.mw-special-Newsletters .mw-datatable td,
.mw-special-Newsletters .mw-datatable th {
--
To view, visit https://gerrit.wikimedia.org/r/378867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b45ce9ef92c0101cc2de68777d55c222354a8eb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Eugene233 <agboreug...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
