jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/378886 )
Change subject: Skip SPARQL type in missing_commonscat_links.py ...................................................................... Skip SPARQL type in missing_commonscat_links.py This script was crashing when processing nl-wd with: ``` File "missing_commonscat_links.py", line 115, in lookupSourceField for field in countryconfig.get('fields'): TypeError: 'NoneType' object is not iterable ``` because SPARQL sources do not use fields. This script is not meant to be used for SPARQL sources, we just skip them silently. Bug: T175899 Change-Id: I5b968f8c9ad4beabf3d76ed339e4b018ff14bded --- M erfgoedbot/missing_commonscat_links.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Lokal Profil: Looks good to me, but someone else must approve Jean-Frédéric: Looks good to me, approved jenkins-bot: Verified diff --git a/erfgoedbot/missing_commonscat_links.py b/erfgoedbot/missing_commonscat_links.py index fd5898d..85974a1 100644 --- a/erfgoedbot/missing_commonscat_links.py +++ b/erfgoedbot/missing_commonscat_links.py @@ -33,6 +33,10 @@ # missingCommonscatPage not set, just skip silently. return False + if countryconfig.get('type') == 'sparql': + # This script does not (yet) work for SPARQL sources, skip silently + return False + commonscatField = lookupSourceField(u'commonscat', countryconfig) if not commonscatField: # Field is missing. Something is seriously wrong, but we just skip it -- To view, visit https://gerrit.wikimedia.org/r/378886 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b968f8c9ad4beabf3d76ed339e4b018ff14bded Gerrit-PatchSet: 2 Gerrit-Project: labs/tools/heritage Gerrit-Branch: master Gerrit-Owner: Jean-Frédéric <jeanfrederic.w...@gmail.com> Gerrit-Reviewer: Jean-Frédéric <jeanfrederic.w...@gmail.com> Gerrit-Reviewer: Lokal Profil <lokal.pro...@gmail.com> Gerrit-Reviewer: Multichill <maar...@mdammers.nl> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits