jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378897 )
Change subject: Remove unused variables from closures
......................................................................
Remove unused variables from closures
Change-Id: I5d2e0cd423a4080677f8517bcf3dcee10bf44799
---
M resources/src/mediawiki.special/mediawiki.special.changeslist.visitedstatus.js
M
resources/src/mediawiki.special/mediawiki.special.preferences.convertmessagebox.js
M resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchQueue.js
M resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
M resources/src/mediawiki/mediawiki.checkboxtoggle.js
M tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js
M
tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
M tests/qunit/suites/resources/mediawiki/mediawiki.errorLogger.test.js
8 files changed, 16 insertions(+), 16 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/resources/src/mediawiki.special/mediawiki.special.changeslist.visitedstatus.js
b/resources/src/mediawiki.special/mediawiki.special.changeslist.visitedstatus.js
index 954e074..6b25327 100644
---
a/resources/src/mediawiki.special/mediawiki.special.changeslist.visitedstatus.js
+++
b/resources/src/mediawiki.special/mediawiki.special.changeslist.visitedstatus.js
@@ -1,7 +1,7 @@
/*!
* JavaScript for Special:Watchlist
*/
-( function ( mw, $ ) {
+( function ( $ ) {
$( function () {
$( '.mw-changeslist-line-watched .mw-title a' ).on( 'click',
function () {
$( this )
@@ -9,4 +9,4 @@
.removeClass( 'mw-changeslist-line-watched' );
} );
} );
-}( mediaWiki, jQuery ) );
+}( jQuery ) );
diff --git
a/resources/src/mediawiki.special/mediawiki.special.preferences.convertmessagebox.js
b/resources/src/mediawiki.special/mediawiki.special.preferences.convertmessagebox.js
index cee7382..e6b7432 100644
---
a/resources/src/mediawiki.special/mediawiki.special.preferences.convertmessagebox.js
+++
b/resources/src/mediawiki.special/mediawiki.special.preferences.convertmessagebox.js
@@ -1,9 +1,9 @@
/*!
* JavaScript for Special:Preferences: Check for successbox to replace with
notifications.
*/
-( function ( mw, $ ) {
+( function ( $ ) {
$( function () {
var convertmessagebox = require(
'mediawiki.notification.convertmessagebox' );
convertmessagebox();
} );
-}( mediaWiki, jQuery ) );
+}( jQuery ) );
diff --git
a/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchQueue.js
b/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchQueue.js
index 7ee98bb..3639525 100644
--- a/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchQueue.js
+++ b/resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchQueue.js
@@ -4,7 +4,7 @@
* @copyright 2011-2016 VisualEditor Team and others; see AUTHORS.txt
* @license The MIT License (MIT); see LICENSE.txt
*/
-( function ( $, mw ) {
+( function ( mw ) {
/**
* MediaWiki media resource queue.
@@ -79,4 +79,4 @@
mw.widgets.MediaSearchQueue.prototype.getSearchQuery = function () {
return this.getParams().gsrsearch;
};
-}( jQuery, mediaWiki ) );
+}( mediaWiki ) );
diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
b/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
index 5ba9481..cd937f7 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js
@@ -4,7 +4,7 @@
* @copyright 2011-2015 MediaWiki Widgets Team and others; see AUTHORS.txt
* @license The MIT License (MIT); see LICENSE.txt
*/
-( function ( $, mw ) {
+( function ( mw ) {
/**
* Creates an mw.widgets.TitleSearchWidget object.
@@ -102,4 +102,4 @@
return response.query || {};
};
-}( jQuery, mediaWiki ) );
+}( mediaWiki ) );
diff --git a/resources/src/mediawiki/mediawiki.checkboxtoggle.js
b/resources/src/mediawiki/mediawiki.checkboxtoggle.js
index 36090ea..76bc86c 100644
--- a/resources/src/mediawiki/mediawiki.checkboxtoggle.js
+++ b/resources/src/mediawiki/mediawiki.checkboxtoggle.js
@@ -9,7 +9,7 @@
* Jeroen De Dauw <jeroendedauw at gmail dot com>
*/
-( function ( mw, $ ) {
+( function ( $ ) {
'use strict';
$( function () {
@@ -35,4 +35,4 @@
} );
-}( mediaWiki, jQuery ) );
+}( jQuery ) );
diff --git a/tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js
b/tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js
index 0c91e43..d51dc37 100644
--- a/tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js
+++ b/tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js
@@ -1,4 +1,4 @@
-( function ( mw, $ ) {
+( function ( $ ) {
var loremIpsum = 'Lorem ipsum dolor sit amet, consectetuer adipiscing
elit.';
QUnit.module( 'jquery.makeCollapsible', QUnit.newMwEnvironment() );
@@ -374,4 +374,4 @@
$clone.find( '.mw-collapsible-toggle a' ).trigger( 'click' );
} );
-}( mediaWiki, jQuery ) );
+}( jQuery ) );
diff --git
a/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
b/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
index 35b6b71..14c2bb4 100644
---
a/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
+++
b/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
@@ -1,4 +1,4 @@
-( function ( mw, $ ) {
+( function ( $ ) {
QUnit.module( 'mediawiki.special.recentchanges',
QUnit.newMwEnvironment() );
// TODO: verify checkboxes == [ 'nsassociated', 'nsinvert' ]
@@ -61,4 +61,4 @@
// DOM cleanup
$env.remove();
} );
-}( mediaWiki, jQuery ) );
+}( jQuery ) );
diff --git
a/tests/qunit/suites/resources/mediawiki/mediawiki.errorLogger.test.js
b/tests/qunit/suites/resources/mediawiki/mediawiki.errorLogger.test.js
index 46d7837..2a4d991 100644
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.errorLogger.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.errorLogger.test.js
@@ -1,4 +1,4 @@
-( function ( $, mw ) {
+( function ( mw ) {
QUnit.module( 'mediawiki.errorLogger', QUnit.newMwEnvironment() );
QUnit.test( 'installGlobalHandler', function ( assert ) {
@@ -39,4 +39,4 @@
assert.strictEqual( w.onerror( errorMessage, errorUrl,
errorLine ), true,
'Global handler preserves true return from previous
handler' );
} );
-}( jQuery, mediaWiki ) );
+}( mediaWiki ) );
--
To view, visit https://gerrit.wikimedia.org/r/378897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d2e0cd423a4080677f8517bcf3dcee10bf44799
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Fomafix <foma...@googlemail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
