jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/375703 )
Change subject: build: Add --coverage-html to phpunit command
......................................................................
build: Add --coverage-html to phpunit command
This validates @covers tags on each commit.
Change-Id: I38eed66bc556e89559986efbb39d59134be40ade
---
M composer.json
M tests/ReaderTest.php
M tests/ValidateTest.php
3 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
Krinkle: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/composer.json b/composer.json
index 65b44dd..434ab81 100644
--- a/composer.json
+++ b/composer.json
@@ -30,7 +30,7 @@
"fix": "phpcbf",
"test": [
"parallel-lint . --exclude vendor",
- "phpunit",
+ "phpunit --coverage-html coverage",
"phpcs -p -s"
]
}
diff --git a/tests/ReaderTest.php b/tests/ReaderTest.php
index 3a7cfbe..6aea368 100644
--- a/tests/ReaderTest.php
+++ b/tests/ReaderTest.php
@@ -7,7 +7,7 @@
/**
* @group Media
- * @covers Reader
+ * @covers \XMPReader\Reader
*/
class ReaderTest extends PHPUnit_Framework_TestCase {
@@ -29,7 +29,7 @@
* @throws \Exception
* @dataProvider provideXMPParse
*
- * @covers Reader::parse
+ * @covers \XMPReader\Reader::parse
*/
public function testXMPParse( $xmp, $expected, $info ) {
if ( !is_string( $xmp ) || !is_array( $expected ) ) {
@@ -90,7 +90,7 @@
* @todo This is based on what the standard says. Need to find a real
* world example file to double check the support for this is right.
*
- * @covers Reader::parseExtended
+ * @covers \XMPReader\Reader::parseExtended
*/
public function testExtendedXMP() {
$xmpPath = __DIR__ . '/data/';
@@ -122,7 +122,7 @@
* This test has an extended XMP block with a wrong guid (md5sum)
* and thus should only return the StandardXMP, not the ExtendedXMP.
*
- * @covers Reader::parseExtended
+ * @covers \XMPReader\Reader::parseExtended
*/
public function testExtendedXMPWithWrongGUID() {
$xmpPath = __DIR__ . '/data/';
@@ -153,7 +153,7 @@
* Have a high offset to simulate a missing packet,
* which should cause it to ignore the ExtendedXMP packet.
*
- * @covers Reader::parseExtended
+ * @covers \XMPReader\Reader::parseExtended
*/
public function testExtendedXMPMissingPacket() {
$xmpPath = __DIR__ . '/data/';
@@ -182,7 +182,7 @@
/**
* Test for multi-section, hostile XML
- * @covers Reader::checkParseSafety
+ * @covers \XMPReader\Reader::checkParseSafety
*/
public function testCheckParseSafety() {
// Test for detection
diff --git a/tests/ValidateTest.php b/tests/ValidateTest.php
index 88644b6..f218437 100644
--- a/tests/ValidateTest.php
+++ b/tests/ValidateTest.php
@@ -13,7 +13,7 @@
/**
* @dataProvider provideDates
- * @covers XMPValidate::validateDate
+ * @covers \XMPReader\Validate::validateDate
*/
public function testValidateDate( $value, $expected ) {
// The method should modify $value.
--
To view, visit https://gerrit.wikimedia.org/r/375703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38eed66bc556e89559986efbb39d59134be40ade
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/libs/XMPReader
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
