EBernhardson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379119 )
Change subject: Javascript timestamps are in ms, not s
......................................................................
Javascript timestamps are in ms, not s
The timeout was intended to be set to 2 days, but due to
a mixup between millis and seconds it was only set to about
3 minutes.
Additionally add an early exit for navigator.doNotTrack, as
event logging won't send the events anyways.
Bug: T174106
Change-Id: I58517c23416822790d93ed714140b6294a8880ad
(cherry picked from commit a3d63b999c3e1c15db66f524548dcddec85db998)
---
M modules/ext.wikimediaEvents.humanSearchRelevance.js
1 file changed, 12 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents
refs/changes/19/379119/1
diff --git a/modules/ext.wikimediaEvents.humanSearchRelevance.js
b/modules/ext.wikimediaEvents.humanSearchRelevance.js
index 5515399..0861666 100644
--- a/modules/ext.wikimediaEvents.humanSearchRelevance.js
+++ b/modules/ext.wikimediaEvents.humanSearchRelevance.js
@@ -19,6 +19,17 @@
return options[ Math.floor( parsed / step ) ];
}
+ // See
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/doNotTrack
+ // Taken from https://www.npmjs.com/package/dnt-polyfill
+ if ( window.doNotTrack === '1' ||
+ window.navigator && (
+ window.navigator.doNotTrack === '1' ||
+ window.navigator.doNotTrack === 'yes' ||
+ window.navigator.msDoNotTrack === '1'
+ ) ) {
+ return;
+ }
+
// Page is not part of this test
if ( !mw.config.exists( 'wgWMESearchRelevancePages' ) ) {
return;
@@ -93,7 +104,7 @@
}
// If we can't record that the survey shouldn't be
duplicated, just
// opt them out of the survey all together.
- if ( !mw.storage.set( timeoutKey, now + 2 * 86400 ) ) {
+ if ( !mw.storage.set( timeoutKey, now + 2 * 86400000 )
) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/379119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58517c23416822790d93ed714140b6294a8880ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.30.0-wmf.19
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
