jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379125 )
Change subject: Dont reach through window to access navigator
......................................................................
Dont reach through window to access navigator
Avoid accessing navigator via window. (Causes errors to be missed by
ESLint static analysis, e.g. in case of typos it would normally produce
an lint warning for unknown global but now will not). The check is also
redundant given all browsers implement this global and have for a long
time.
Change-Id: I4a66b1cb34c48c2f507e3c3689b611874777e8d1
---
M modules/ext.wikimediaEvents.humanSearchRelevance.js
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.wikimediaEvents.humanSearchRelevance.js
b/modules/ext.wikimediaEvents.humanSearchRelevance.js
index 0861666..9e36352 100644
--- a/modules/ext.wikimediaEvents.humanSearchRelevance.js
+++ b/modules/ext.wikimediaEvents.humanSearchRelevance.js
@@ -22,11 +22,10 @@
// See
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/doNotTrack
// Taken from https://www.npmjs.com/package/dnt-polyfill
if ( window.doNotTrack === '1' ||
- window.navigator && (
- window.navigator.doNotTrack === '1' ||
- window.navigator.doNotTrack === 'yes' ||
- window.navigator.msDoNotTrack === '1'
- ) ) {
+ navigator.doNotTrack === '1' ||
+ navigator.doNotTrack === 'yes' ||
+ navigator.msDoNotTrack === '1'
+ ) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/379125
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a66b1cb34c48c2f507e3c3689b611874777e8d1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
