VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379154 )
Change subject: Align added to watchlist tooltip to style guide and replace
deprecated icon
......................................................................
Align added to watchlist tooltip to style guide and replace deprecated icon
Aligning “This topic has been added to your watchlist.” tooltip to
style guide by:
- removing `opacity` of tooltip
- aligning `padding` with popups elsewhere
- make icon same color as surrounding text
- limiting icon size to `32px` as it shouldn't be bigger than f.e.
“Browse topics” icon
Also exchanging deprecated 'watchlist' icon with 'unStar' icon.
Bug: T176296
Change-Id: Ibb79740462a9c9a880cc71fbea70207ef47525bf
---
M handlebars/flow_subscribed.partial.handlebars
M modules/styles/board/topic/titlebar.less
M modules/styles/mediawiki.ui/tooltips.less
3 files changed, 23 insertions(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/54/379154/1
diff --git a/handlebars/flow_subscribed.partial.handlebars
b/handlebars/flow_subscribed.partial.handlebars
index 26a5947..ed0c051 100644
--- a/handlebars/flow_subscribed.partial.handlebars
+++ b/handlebars/flow_subscribed.partial.handlebars
@@ -1,7 +1,9 @@
-<div class="flow-notification-tooltip-icon"><span class="mw-ui-icon
mw-ui-icon-element mw-ui-icon-watchlist"></span></div>
+<div class="flow-notification-tooltip-icon"><span class="mw-ui-icon
mw-ui-icon-element mw-ui-icon-unStar"></span></div>
<p class="flow-notification-tooltip-title">
+ <strong>
{{!-- flow-topic-notification-subscribe-title and
flow-board-notification-subscribe-title --}}
{{l10n (concat "flow-" type "-notification-subscribe-title") user }}
+ <strong>
</p>
<p class="flow-notification-tooltip-content">
{{!-- flow-topic-notification-subscribe-description and
flow-board-notification-subscribe-description --}}
diff --git a/modules/styles/board/topic/titlebar.less
b/modules/styles/board/topic/titlebar.less
index 0097310..4abc566 100644
--- a/modules/styles/board/topic/titlebar.less
+++ b/modules/styles/board/topic/titlebar.less
@@ -94,17 +94,26 @@
.flow-notification-tooltip-topicsub {
width: 15em;
}
-.flow-notification-tooltip-icon {
- font-size: 2.5em;
- text-align: center;
+.flow-notification-tooltip-icon {
.mw-ui-icon {
- display: inline-block;
+ display: block;
+ margin-left: auto;
+ margin-right: auto;
+ opacity: 0.87; // equals `#222` on background-color `#fff`
+
+ &.mw-ui-icon-star { // Overwrite default `.mw-ui-icon`
properties
+ min-width: 32px;
+ width: 32px;
+ max-width: 32px;
+ min-height: 32px;
+ font-size: 32px;
+ line-height: 1;
+ }
}
}
.flow-notification-tooltip-title {
font-size: 1em;
- font-weight: bold;
}
.flow-undo {
diff --git a/modules/styles/mediawiki.ui/tooltips.less
b/modules/styles/mediawiki.ui/tooltips.less
index 01f3dfa..9259ee2 100644
--- a/modules/styles/mediawiki.ui/tooltips.less
+++ b/modules/styles/mediawiki.ui/tooltips.less
@@ -16,16 +16,16 @@
Styleguide 4.0.
*/
.flow-ui-tooltip {
+ background-color: #fff;
+ color: @colorText;
position: relative;
top: 1px;
display: inline-block;
- padding: 0.5em;
- background: #fff;
- color: @colorText;
- word-wrap: break-word;
border-radius: @borderRadius;
- .box-shadow( ~'0 2px 0 0 @{colorGray12}, 0 0 1px 0 @{colorGray12}' );
- opacity: 0.9;
+ padding: 0.571em 0.857em; // equals to ~8px ~12px with base `font-size`
+ .box-shadow( ~'0 2px 2px 0 rgba(0, 0, 0, 0.25)' );
+ font-size: 0.875em; // not inherited from div#bodyContent, as we insert
at body
+ word-wrap: break-word;
z-index: 99;
a {
@@ -34,8 +34,6 @@
color: #fff !important; /* stylelint-disable-line
declaration-no-important */
font-weight: bold;
}
-
- font-size: 0.875em; // not inherited from div#bodyContent, as we insert
at body
#bodyContent & { /* stylelint-disable-line selector-no-id */
font-size: 1em;
--
To view, visit https://gerrit.wikimedia.org/r/379154
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb79740462a9c9a880cc71fbea70207ef47525bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
