jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378837 )
Change subject: Do not run tests that depend on curl if it is not loaded
......................................................................
Do not run tests that depend on curl if it is not loaded
Bug: T176193
Change-Id: Ia7b9b0196f800eb14463acc2a24df5ac1e48f3ed
---
M tests/phpunit/includes/http/HttpTest.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/http/HttpTest.php
b/tests/phpunit/includes/http/HttpTest.php
index 3693a27..3790e3a 100644
--- a/tests/phpunit/includes/http/HttpTest.php
+++ b/tests/phpunit/includes/http/HttpTest.php
@@ -497,6 +497,10 @@
* @dataProvider provideCurlConstants
*/
public function testCurlConstants( $value ) {
+ if ( !extension_loaded( 'curl' ) ) {
+ $this->markTestSkipped( "PHP extension 'curl' is not
loaded, skipping." );
+ }
+
$this->assertTrue( defined( $value ), $value . ' not defined' );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/378837
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7b9b0196f800eb14463acc2a24df5ac1e48f3ed
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Huji <huji.h...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
