jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/369460 )
Change subject: Add flaggedrevs.fr_user index
......................................................................
Add flaggedrevs.fr_user index
Bug: T172207
Change-Id: Ida70f029a9ce586ebfb57be248823f5b7dc43c6d
---
M backend/schema/FlaggedRevsUpdater.hooks.php
M backend/schema/mysql/FlaggedRevs.sql
A backend/schema/mysql/patch-fr_user-index.sql
M backend/schema/postgres/FlaggedRevs.pg.sql
A backend/schema/postgres/patch-fr_user-index.sql
5 files changed, 19 insertions(+), 10 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
Umherirrender: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/backend/schema/FlaggedRevsUpdater.hooks.php
b/backend/schema/FlaggedRevsUpdater.hooks.php
index c399574..bf6b7ec 100644
--- a/backend/schema/FlaggedRevsUpdater.hooks.php
+++ b/backend/schema/FlaggedRevsUpdater.hooks.php
@@ -25,6 +25,7 @@
$du->addExtensionUpdate( [
'FlaggedRevsUpdaterHooks::doFlaggedRevsRevTimestamp',
"$base/patch-fr_page_rev-index.sql" ] );
$du->addExtensionTable( 'flaggedrevs_statistics',
"$base/patch-flaggedrevs_statistics.sql" );
+ $du->addExtensionIndex( 'flaggedrevs', 'fr_user',
"$base/patch-fr_user-index.sql" );
} elseif ( $wgDBtype == 'postgres' ) {
$base = __DIR__ . '/postgres';
@@ -46,6 +47,7 @@
$du->addExtensionUpdate( [
'FlaggedRevsUpdaterHooks::doFlaggedRevsRevTimestamp',
"$base/patch-fr_page_rev-index.sql" ] );
$du->addExtensionTable( 'flaggedrevs_statistics',
"$base/patch-flaggedrevs_statistics.sql" );
+ $du->addExtensionIndex( 'flaggedrevs', 'fr_user',
"$base/patch-fr_user-index.sql" );
} elseif ( $wgDBtype == 'sqlite' ) {
$base = __DIR__ . '/mysql';
diff --git a/backend/schema/mysql/FlaggedRevs.sql
b/backend/schema/mysql/FlaggedRevs.sql
index a783f6d..f9ed404 100644
--- a/backend/schema/mysql/FlaggedRevs.sql
+++ b/backend/schema/mysql/FlaggedRevs.sql
@@ -31,12 +31,11 @@
fpp_rev_id integer unsigned NOT NULL,
-- Time of the first edit after the last revision reviewed to this level
fpp_pending_since varbinary(14) NOT NULL,
-
+
PRIMARY KEY (fpp_page_id,fpp_quality)
) /*$wgDBTableOptions*/;
-CREATE INDEX /*i*/fpp_quality_pending
- ON /*_*/flaggedpage_pending (fpp_quality,fpp_pending_since);
+CREATE INDEX /*i*/fpp_quality_pending ON /*_*/flaggedpage_pending
(fpp_quality,fpp_pending_since);
-- This stores all of our revision reviews; it is the main table
-- The template/file version data is stored in the next two tables
@@ -53,7 +52,7 @@
fr_timestamp varbinary(14) NOT NULL,
-- Store the precedence level
fr_quality tinyint(1) NOT NULL default 0,
- -- Store tag metadata as newline separated,
+ -- Store tag metadata as newline separated,
-- colon separated tag:value pairs
fr_tags mediumblob NOT NULL,
-- Comma-separated list of flags:
@@ -74,6 +73,7 @@
CREATE INDEX /*i*/fr_page_qal_rev ON /*_*/flaggedrevs
(fr_page_id,fr_quality,fr_rev_id);
CREATE INDEX /*i*/fr_page_qal_time ON /*_*/flaggedrevs
(fr_page_id,fr_quality,fr_rev_timestamp);
CREATE INDEX /*i*/fr_img_sha1 ON /*_*/flaggedrevs (fr_img_sha1);
+CREATE INDEX /*i*/fr_user ON /*_*/flaggedrevs (fr_user);
-- This stores all of our transclusion revision pointers
CREATE TABLE IF NOT EXISTS /*_*/flaggedtemplates (
@@ -83,7 +83,7 @@
ft_title varchar(255) binary NOT NULL default '',
-- Revisions ID used when reviewed
ft_tmp_rev_id integer unsigned NULL,
-
+
PRIMARY KEY (ft_rev_id,ft_namespace,ft_title)
) /*$wgDBTableOptions*/;
@@ -96,7 +96,7 @@
fi_img_timestamp varbinary(14) NULL,
-- Statistically unique SHA-1 key
fi_img_sha1 varbinary(32) NOT NULL default '',
-
+
PRIMARY KEY (fi_rev_id,fi_name)
) /*$wgDBTableOptions*/;
@@ -126,10 +126,8 @@
ftr_title varchar(255) binary NOT NULL default ''
) /*$wgDBTableOptions*/;
-CREATE UNIQUE INDEX /*i*/frt_from_namespace_title
- ON /*_*/flaggedrevs_tracking (ftr_from,ftr_namespace,ftr_title);
-CREATE INDEX /*i*/frt_namespace_title_from
- ON /*_*/flaggedrevs_tracking (ftr_namespace,ftr_title,ftr_from);
+CREATE UNIQUE INDEX /*i*/frt_from_namespace_title ON /*_*/flaggedrevs_tracking
(ftr_from,ftr_namespace,ftr_title);
+CREATE INDEX /*i*/frt_namespace_title_from ON /*_*/flaggedrevs_tracking
(ftr_namespace,ftr_title,ftr_from);
-- This stores user demotions and stats
CREATE TABLE IF NOT EXISTS /*_*/flaggedrevs_promote (
diff --git a/backend/schema/mysql/patch-fr_user-index.sql
b/backend/schema/mysql/patch-fr_user-index.sql
new file mode 100644
index 0000000..3306493
--- /dev/null
+++ b/backend/schema/mysql/patch-fr_user-index.sql
@@ -0,0 +1,4 @@
+-- Add fr_user column index
+
+ALTER TABLE /*$wgDBprefix*/flaggedrevs
+ ADD INDEX (fr_user);
diff --git a/backend/schema/postgres/FlaggedRevs.pg.sql
b/backend/schema/postgres/FlaggedRevs.pg.sql
index e3ec350..08d8b14 100644
--- a/backend/schema/postgres/FlaggedRevs.pg.sql
+++ b/backend/schema/postgres/FlaggedRevs.pg.sql
@@ -43,6 +43,7 @@
CREATE INDEX page_qal_rev ON flaggedrevs (fr_page_id,fr_quality,fr_rev_id);
CREATE INDEX page_qal_time ON flaggedrevs
(fr_page_id,fr_quality,fr_rev_timestamp);
CREATE INDEX fr_img_sha1 ON flaggedrevs (fr_img_sha1);
+CREATE INDEX fr_user ON flaggedrevs (fr_user);
CREATE TABLE flaggedtemplates (
ft_rev_id BIGINT NOT NULL DEFAULT 0 ,
diff --git a/backend/schema/postgres/patch-fr_user-index.sql
b/backend/schema/postgres/patch-fr_user-index.sql
new file mode 100644
index 0000000..3306493
--- /dev/null
+++ b/backend/schema/postgres/patch-fr_user-index.sql
@@ -0,0 +1,4 @@
+-- Add fr_user column index
+
+ALTER TABLE /*$wgDBprefix*/flaggedrevs
+ ADD INDEX (fr_user);
--
To view, visit https://gerrit.wikimedia.org/r/369460
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida70f029a9ce586ebfb57be248823f5b7dc43c6d
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Luke081515 <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
