Jakob has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379233 )
Change subject: Reload page to test persistence in browser test.
......................................................................
Reload page to test persistence in browser test.
Bug: T164742
Change-Id: I391d8cbbb89c96dbc394c005840d2e0cb4480554
---
M tests/browser/features/forms.feature
M tests/browser/features/step_definitions/forms_steps.rb
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme
refs/changes/33/379233/1
diff --git a/tests/browser/features/forms.feature
b/tests/browser/features/forms.feature
index 537fe03..3dc28f9 100644
--- a/tests/browser/features/forms.feature
+++ b/tests/browser/features/forms.feature
@@ -54,6 +54,7 @@
When I click the Forms list add button
And I enter "whatever" as the "en" form representation
And I save the Form
+ And I reload the page
Then "whatever" should be displayed as the "en" representation of the Form
diff --git a/tests/browser/features/step_definitions/forms_steps.rb
b/tests/browser/features/step_definitions/forms_steps.rb
index 7bbe413..35aadc0 100644
--- a/tests/browser/features/step_definitions/forms_steps.rb
+++ b/tests/browser/features/step_definitions/forms_steps.rb
@@ -62,10 +62,11 @@
When(/^I save the Form$/) do
# TODO: Had some problems here with element clickability, but failed to
reproduce. Fix is probably needed
@form_I_am_currently_editing.save_element.when_visible.click
+ until @form_I_am_currently_editing.edit_element.exists? do sleep 1 end #
making sure the request is sent
end
Then(/^"(.*?)" should be displayed as the "(.*?)" representation of the
Form$/) do |value, language|
- has_representation_with_value =
@form_I_am_currently_editing.representations.any? do |representation|
+ has_representation_with_value = on(LexemePage).forms.map { |f|
f.representations.to_a }.to_a.flatten.any? do |representation|
representation.value_element.when_visible.text == value
representation.language_element.when_visible.text == language
end
--
To view, visit https://gerrit.wikimedia.org/r/379233
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I391d8cbbb89c96dbc394c005840d2e0cb4480554
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Jakob <jakob.warkot...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
