jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378999 )
Change subject: Chore: Fix double spacing in Page template
......................................................................
Chore: Fix double spacing in Page template
In the Page-content, which has inner bottom spacing due to the spacing
from Paper, the last element's margin could accumulate with the bottom
padding, producing double-space.
As such, make the last element inside the content not have any extrinsic
spacing (margin) that could add to the inner spacing in the Page.
Change-Id: I78635f111caf95ec08e307293269e03b3f630195
---
M src/common/components/page/page.css
M src/common/components/paper/paper.css
2 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Niedzielski: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/common/components/page/page.css
b/src/common/components/page/page.css
index c819516..7a28309 100644
--- a/src/common/components/page/page.css
+++ b/src/common/components/page/page.css
@@ -17,4 +17,11 @@
color: var(--wmui-color-base20);
}
-.Page-content {}
\ No newline at end of file
+.Page-content {}
+
+.Page-content>:last-child {
+ /* Remove extrinsic bottom spacing (margin) from the last element in the
+ content, given that it will accumulate with padding in the Paper sheet and
+ present double spacing at the bottom of the container */
+ margin-bottom: 0;
+}
\ No newline at end of file
diff --git a/src/common/components/paper/paper.css
b/src/common/components/paper/paper.css
index e56522a..3c22870 100644
--- a/src/common/components/paper/paper.css
+++ b/src/common/components/paper/paper.css
@@ -13,5 +13,5 @@
.Paper-separator {
height: 1px;
background-color: var(--wmui-color-base80);
- margin: var(--space) calc(-1*var(--space));
-}
\ No newline at end of file
+ margin: var(--space) calc(-1 * var(--space));
+}
--
To view, visit https://gerrit.wikimedia.org/r/378999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78635f111caf95ec08e307293269e03b3f630195
Gerrit-PatchSet: 3
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
