MaxSem has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379331 )
Change subject: Fix ip_changes insert counting
......................................................................
Fix ip_changes insert counting
Change-Id: I02b457d9dcaadc97eead623e42a5a1ccf8335724
---
M maintenance/populateIpChanges.php
1 file changed, 4 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/31/379331/1
diff --git a/maintenance/populateIpChanges.php
b/maintenance/populateIpChanges.php
index 2b2a2b4..40a596c 100644
--- a/maintenance/populateIpChanges.php
+++ b/maintenance/populateIpChanges.php
@@ -110,14 +110,11 @@
}
}
- $dbw->insert(
- 'ip_changes',
- $insertRows,
- __METHOD__,
- 'IGNORE'
- );
+ if ( $insertRows ) {
+ $dbw->insert( 'ip_changes', $insertRows,
__METHOD__, 'IGNORE' );
- $inserted += $dbw->affectedRows();
+ $inserted += $dbw->affectedRows();
+ }
$lbFactory->waitForReplication();
usleep( $throttle * 1000 );
--
To view, visit https://gerrit.wikimedia.org/r/379331
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02b457d9dcaadc97eead623e42a5a1ccf8335724
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
