Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/379422 )

Change subject: phab/aphlict: use groups instead of gid, remove require
......................................................................

phab/aphlict: use groups instead of gid, remove require

follow-up to Change-Id I582deafa4faea0f45 which introduced
a puppet error when it tries to create the user "aphlict" due
to missing group "aphlict" even though it should be created and
there is a "require" for it.

The "gid" parameter is for a number, while "groups" should be for
a group name.

Following examples in puppet docs, there is also no require needed
between group and user like that.

Bug: T765
Change-Id: Ia9b72f9caf26fb5cc2a0971f0673d283b2de31ee
---
M modules/phabricator/manifests/aphlict.pp
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/22/379422/1

diff --git a/modules/phabricator/manifests/aphlict.pp 
b/modules/phabricator/manifests/aphlict.pp
index e76b9f0..c85feda 100644
--- a/modules/phabricator/manifests/aphlict.pp
+++ b/modules/phabricator/manifests/aphlict.pp
@@ -73,11 +73,10 @@
     }
 
     user { $user:
-        gid     => $group,
+        groups  => $group,
         shell   => '/bin/false',
         home    => '/var/run/aphlict',
         system  => true,
-        require => Group[$group],
     }
 
     base::service_unit { 'aphlict':

-- 
To view, visit https://gerrit.wikimedia.org/r/379422
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9b72f9caf26fb5cc2a0971f0673d283b2de31ee
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to