jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379515 )
Change subject: BSFoundation: Removed the cores "ScriptBlock" functionality ...
......................................................................
BSFoundation: Removed the cores "ScriptBlock" functionality ...
... cause i am not even old enough to know when this was in use ;)
Change-Id: Iec7f5727dd250646993ca0d6817ab395929ad763
---
M includes/Core.class.php
M includes/CoreHooks.php
2 files changed, 0 insertions(+), 31 deletions(-)
Approvals:
Robert Vogel: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Core.class.php b/includes/Core.class.php
index 3775882..2048a6b 100644
--- a/includes/Core.class.php
+++ b/includes/Core.class.php
@@ -102,8 +102,6 @@
*/
protected static $aUserMiniProfiles = array();
- protected static $aClientScriptBlocks = array();
-
protected static $bHtmlFormClassLoaded = false;
/**
@@ -718,25 +716,5 @@
public static function getMediaWikiWebrootPath() {
global $wgScriptPath;
return str_replace($wgScriptPath, '',
self::getMediaWikiIncludePath());
- }
-
- public static function getClientScriptBlocks() {
- return self::$aClientScriptBlocks;
- }
-
- /**
- * Use this to place javascript logic _below_ the including script
files. Therefore you can benefit from the available frameworks like
BlueSpiceFramework, ExtJS and jQuery.
- * @param String $sExtensionKey The name of the extension. This is just
for creating a nice comment within the script-Tags
- * @param String $sCode The JavaScript code, that should be executed
after all scriptfiles have been included
- * @param String $sUniqueKey (Optional) If provided the script block
gets saved in with a unique key and therefore will not be registered multiple
times.
- * @deprecated Use MediaWikis Outpage interface instead
- */
- public static function registerClientScriptBlock( $sExtensionKey,
$sCode, $sUniqueKey = '' ) {
- wfDeprecated(__METHOD__);
- if( !empty( $sUniqueKey ) ) {
- self::$aClientScriptBlocks[$sUniqueKey] = array(
$sExtensionKey, $sCode );
- } else {
- self::$aClientScriptBlocks[] = array( $sExtensionKey,
$sCode );
- }
}
}
diff --git a/includes/CoreHooks.php b/includes/CoreHooks.php
index 9955cf2..9b41d5e 100755
--- a/includes/CoreHooks.php
+++ b/includes/CoreHooks.php
@@ -83,15 +83,6 @@
$wgFavicon = BsConfig::get( 'MW::FaviconPath' );
- $aScriptBlocks = BsCore::getClientScriptBlocks();
- foreach ( $aScriptBlocks as $sKey => $aClientScriptBlock ) {
- $aOutput[] = '<script type="text/javascript">';
- $aOutput[] = '//'.$aClientScriptBlock[0].' ('.$sKey.')';
- $aOutput[] = $aClientScriptBlock[1];
- $aOutput[] = '</script>';
- $out->addScript( implode( "\n", $aOutput ) );
- }
-
//Make some variables available on client side:
global $wgEnableUploads, $wgMaxUploadSize;
$iMaxPhpUploadSize = (int) ini_get('upload_max_filesize');
--
To view, visit https://gerrit.wikimedia.org/r/379515
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec7f5727dd250646993ca0d6817ab395929ad763
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: master
Gerrit-Owner: Pwirth <[email protected]>
Gerrit-Reviewer: Ljonka <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
