EBernhardson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379566 )
Change subject: Attach searchToken and query parameters to visitPage events
......................................................................
Attach searchToken and query parameters to visitPage events
This information is usefull to be able to concretely identify
which search triggered a visitPage (and subsequent checkin)
events. Currently a bit of handwavy guessing has to be applied,
so remove the ambiguity and log directly.
Change-Id: Ie3377333dc23749abbaa46317a02d628da3f5218
---
M modules/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 20 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents
refs/changes/66/379566/1
diff --git a/modules/ext.wikimediaEvents.searchSatisfaction.js
b/modules/ext.wikimediaEvents.searchSatisfaction.js
index bd055a8..a92307b 100644
--- a/modules/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/ext.wikimediaEvents.searchSatisfaction.js
@@ -639,6 +639,22 @@
};
}
+ function createVisitPageEvent() {
+ var referrer = new mw.Uri( document.referrer ),
+ evt = {
+ position: search.resultPosition
+ };
+
+ // Helpfull information for tieing together various events in
the backend
+ if ( referrer.query && referrer.query.searchToken ) {
+ evt.searchToken = referrer.query.searchToken;
+ }
+ if ( referrer.query && referrer.query.search ) {
+ evt.query = referrer.query.search;
+ }
+ return evt;
+ }
+
/**
* Sets up the full text search test.
*
@@ -795,6 +811,8 @@
logEvent( 'esclick', esParams );
} );
+ // From here on is generating the `searchResultPage`
event
+
serpExtras = {
offset: $( '.results-info' ).data(
'mw-num-results-offset' )
};
@@ -844,10 +862,9 @@
logEvent( 'searchResultPage', params );
}
+
if ( search.cameFromSearch ) {
- logEvent( 'visitPage', {
- position: search.resultPosition
- } );
+ logEvent( 'visitPage', createVisitPageEvent() );
interval( checkinTimes, function ( checkin ) {
logEvent( 'checkin', { checkin: checkin } );
} );
--
To view, visit https://gerrit.wikimedia.org/r/379566
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3377333dc23749abbaa46317a02d628da3f5218
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits