jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/376176 )
Change subject: apisandbox.js: Use findFirstSelectableitem instead of
getFirstSelectableItem
......................................................................
apisandbox.js: Use findFirstSelectableitem instead of getFirstSelectableItem
Bug: T76630
Change-Id: Iaf2c9cae0bcd6dd6c486f84b7cf1e2a640fb38f8
Depends-on: Ic12be404eba490e5ce748f0d754a807e12f6ba76
---
M resources/src/mediawiki.special/mediawiki.special.apisandbox.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
Objections:
Anomie: There's a problem with this change, please improve
diff --git a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
index 7e9ad7f..9e8d4f4 100644
--- a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
+++ b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
@@ -1072,7 +1072,7 @@
selectedLabel = selectedLabel.text();
}
menu.clearItems().addItems( formatItems );
- menu.chooseItem( menu.getItemFromLabel(
selectedLabel ) || menu.getFirstSelectableItem() );
+ menu.chooseItem( menu.getItemFromLabel(
selectedLabel ) || menu.findFirstSelectableItem() );
// Fire the event to update field visibilities
Util.onFormatDropdownChange();
--
To view, visit https://gerrit.wikimedia.org/r/376176
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf2c9cae0bcd6dd6c486f84b7cf1e2a640fb38f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
