Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379594 )
Change subject: Hygiene: remove unused attribute. ...................................................................... Hygiene: remove unused attribute. Also spelling. Change-Id: Iea2eeef1ed37f60f4ac59e811c602d371ac00c81 --- M app/src/main/res/layout/view_card_header.xml M app/src/main/res/values/attrs.xml M app/src/main/res/values/styles_dark.xml M app/src/main/res/values/styles_light.xml 4 files changed, 4 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/94/379594/1 diff --git a/app/src/main/res/layout/view_card_header.xml b/app/src/main/res/layout/view_card_header.xml index 1b77cb5..cbb17b5 100644 --- a/app/src/main/res/layout/view_card_header.xml +++ b/app/src/main/res/layout/view_card_header.xml @@ -35,7 +35,7 @@ android:layout_marginLeft="8dp" android:textSize="14sp" android:fontFamily="sans-serif-medium" - android:textColor="?attr/card_hearder_text_color" + android:textColor="?attr/card_header_text_color" android:maxLines="2" android:ellipsize="end" tools:text="Lorem ipsum"/> diff --git a/app/src/main/res/values/attrs.xml b/app/src/main/res/values/attrs.xml index 8108b38..b7d128a 100644 --- a/app/src/main/res/values/attrs.xml +++ b/app/src/main/res/values/attrs.xml @@ -45,7 +45,6 @@ <attr name="blue_switch" format="reference" /> <attr name="header_edit_button" format="reference" /> - <attr name="cardHearderBackground" format="color" /> <attr name="dividerColor" format="color" /> <attr name="hintTextColor" format="color" /> <attr name="listSeparatorColor" format="color" /> @@ -53,7 +52,7 @@ <attr name="bottom_sheet_text_color" format="color" /> <attr name="menu_icon_color" format="color" /> <attr name="bottom_sheet_secondary_text_color" format="color" /> - <attr name="card_hearder_text_color" format="color" /> + <attr name="card_header_text_color" format="color" /> <attr name="text_secondary_color" format="color" /> <attr name="link_color" format="color" /> <attr name="material_secondary_color" format="color" /> diff --git a/app/src/main/res/values/styles_dark.xml b/app/src/main/res/values/styles_dark.xml index ed47a18..ce2198f 100644 --- a/app/src/main/res/values/styles_dark.xml +++ b/app/src/main/res/values/styles_dark.xml @@ -64,7 +64,6 @@ <item name="header_edit_button">@style/HeaderEditButtonDark</item> <item name="edit_preview_color">@color/accent75</item> <item name="horizontal_divider">@style/HorizontalDividerDark</item> - <item name="cardHearderBackground">@color/base20</item> <item name="dividerColor">@color/white20</item> <item name="hintTextColor">@color/white50</item> <item name="listSeparatorColor">@color/white20</item> @@ -72,7 +71,7 @@ <item name="bottom_sheet_text_color">@color/base90</item> <item name="menu_icon_color">@color/white70</item> <item name="bottom_sheet_secondary_text_color">@color/white70</item> - <item name="card_hearder_text_color">@color/base90</item> + <item name="card_header_text_color">@color/base90</item> <item name="text_secondary_color">@color/base70</item> <item name="link_color">@color/accent75</item> <item name="material_primary_color">@color/base100</item> diff --git a/app/src/main/res/values/styles_light.xml b/app/src/main/res/values/styles_light.xml index 089e150..35cc35d 100644 --- a/app/src/main/res/values/styles_light.xml +++ b/app/src/main/res/values/styles_light.xml @@ -65,7 +65,6 @@ <item name="header_edit_button">@style/HeaderEditButtonLight</item> <item name="edit_preview_color">@color/accent50</item> <item name="horizontal_divider">@style/HorizontalDividerLight</item> - <item name="cardHearderBackground">@color/base70</item> <item name="dividerColor">@color/white20</item> <item name="hintTextColor">@color/black38</item> <item name="listSeparatorColor">@color/black12</item> @@ -73,7 +72,7 @@ <item name="bottom_sheet_text_color">@color/base10</item> <item name="menu_icon_color">@color/black54</item> <item name="bottom_sheet_secondary_text_color">@color/black54</item> - <item name="card_hearder_text_color">@color/base20</item> + <item name="card_header_text_color">@color/base20</item> <item name="text_secondary_color">@color/base30</item> <item name="link_color">@color/accent50</item> <item name="material_primary_color">@color/black87</item> -- To view, visit https://gerrit.wikimedia.org/r/379594 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iea2eeef1ed37f60f4ac59e811c602d371ac00c81 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <dbr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits