jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379581 )
Change subject: Use #setupToolbar method to prepare publish button
......................................................................
Use #setupToolbar method to prepare publish button
Change-Id: I346cd5f0639b6d53bf9b038d205634b5a875f337
---
M modules/ui/mw.cx.ui.TranslationView.js
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Divec: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ui/mw.cx.ui.TranslationView.js
b/modules/ui/mw.cx.ui.TranslationView.js
index 628f828..4317e7c 100644
--- a/modules/ui/mw.cx.ui.TranslationView.js
+++ b/modules/ui/mw.cx.ui.TranslationView.js
@@ -31,7 +31,6 @@
this.publishButton = null;
this.publishSettings = null;
this.header = new mw.cx.ui.Header( config );
- this.preparePublishButton();
this.sourceColumn = new mw.cx.ui.SourceColumn( config );
this.targetColumn = new mw.cx.ui.TargetColumn( config );
this.toolsColumn = new mw.cx.ui.ToolsColumn( config );
@@ -105,8 +104,12 @@
/* Methods */
-mw.cx.ui.TranslationView.prototype.preparePublishButton = function () {
+mw.cx.ui.TranslationView.prototype.setupToolbar = function () {
var publishButton, publishSettings;
+
+ // Parent method
+ mw.cx.ui.TranslationView.super.prototype.setupToolbar.apply( this,
arguments );
+
publishButton = new OO.ui.ButtonWidget( {
disabled: true,
flags: [ 'progressive', 'primary' ],
@@ -127,7 +130,6 @@
} );
this.publishButton = publishButton;
this.publishSettings = publishSettings;
- // this.header.$toolbar.prepend( this.publishSettings.$element,
this.publishButton.$element );
this.getToolbar().$actions.append( this.publishSettings.$element,
this.publishButton.$element );
};
--
To view, visit https://gerrit.wikimedia.org/r/379581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I346cd5f0639b6d53bf9b038d205634b5a875f337
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: DLynch <dly...@wikimedia.org>
Gerrit-Reviewer: Divec <da...@troi.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
