Sbisson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379615 )
Change subject: RCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews ...................................................................... RCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews Not used anymore. Change-Id: I1afe736db76eef6ddae5c602d8e24fddfd807a3a --- M includes/DefaultSettings.php M includes/specialpage/ChangesListSpecialPage.php M tests/qunit/suites/resources/mediawiki.rcfilters/dm.FiltersViewModel.test.js 3 files changed, 0 insertions(+), 18 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/15/379615/1 diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index cdb7ce8..9e9ac62 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -6850,14 +6850,6 @@ $wgStructuredChangeFiltersShowPreference = false; /** - * Whether to show the new experimental views (like namespaces, tags, and users) in - * RecentChanges filters - * - * Temporary variable during development and will be removed. - */ -$wgStructuredChangeFiltersEnableExperimentalViews = false; - -/** * Whether to enable RCFilters app on Special:Watchlist * * Temporary variable during development and will be removed. diff --git a/includes/specialpage/ChangesListSpecialPage.php b/includes/specialpage/ChangesListSpecialPage.php index dd0dd92..cf6c8e3 100644 --- a/includes/specialpage/ChangesListSpecialPage.php +++ b/includes/specialpage/ChangesListSpecialPage.php @@ -600,14 +600,7 @@ ) ); - $experimentalStructuredChangeFilters = - $this->getConfig()->get( 'StructuredChangeFiltersEnableExperimentalViews' ); - $out->addJsConfigVars( 'wgStructuredChangeFilters', $jsData['groups'] ); - $out->addJsConfigVars( - 'wgStructuredChangeFiltersEnableExperimentalViews', - $experimentalStructuredChangeFilters - ); $out->addJsConfigVars( 'wgRCFiltersChangeTags', diff --git a/tests/qunit/suites/resources/mediawiki.rcfilters/dm.FiltersViewModel.test.js b/tests/qunit/suites/resources/mediawiki.rcfilters/dm.FiltersViewModel.test.js index 58e4d29..4eec02a 100644 --- a/tests/qunit/suites/resources/mediawiki.rcfilters/dm.FiltersViewModel.test.js +++ b/tests/qunit/suites/resources/mediawiki.rcfilters/dm.FiltersViewModel.test.js @@ -213,9 +213,6 @@ 'group2filter5-desc': 'Description of Filter 5 in Group 2', 'group2filter6-label': 'xGroup 2: Filter 6', 'group2filter6-desc': 'Description of Filter 6 in Group 2' - }, - config: { - wgStructuredChangeFiltersEnableExperimentalViews: true } } ) ); -- To view, visit https://gerrit.wikimedia.org/r/379615 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1afe736db76eef6ddae5c602d8e24fddfd807a3a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Sbisson <sbis...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits