Ema has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379570 )
Change subject: bgp: FSM can be in states != ST_IDLE when the connection is
closed
......................................................................
bgp: FSM can be in states != ST_IDLE when the connection is closed
The BGP FSM can be in ST_ESTABLISHED when the connection is closed.
Do not assert that the state is ST_IDLE.
Bug: T173028
Change-Id: I424912f52d7fbb28420eb33d292d8e433f0c8d12
---
M pybal/bgp/bgp.py
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Ema: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pybal/bgp/bgp.py b/pybal/bgp/bgp.py
index fbc2f28..5ab6fb7 100644
--- a/pybal/bgp/bgp.py
+++ b/pybal/bgp/bgp.py
@@ -2063,8 +2063,6 @@
if protocol is self.estabProtocol:
self.estabProtocol = None
- # self.fsm should still be valid and set to ST_IDLE
- assert self.fsm.state == ST_IDLE
if self.fsm.allowAutomaticStart: self.automaticStart(idleHold=True)
--
To view, visit https://gerrit.wikimedia.org/r/379570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I424912f52d7fbb28420eb33d292d8e433f0c8d12
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/pybal
Gerrit-Branch: 1.14
Gerrit-Owner: Ema <[email protected]>
Gerrit-Reviewer: Ema <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Volans <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
