Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/379723 )

Change subject: Fix toolbar initialization (fixes tool width)
......................................................................

Fix toolbar initialization (fixes tool width)

* Initialize toolbar after setup
* Don't initialize actions toolbar

Change-Id: I7ab2cb29220efad8c6404595871f56b9e6f675f3
---
M modules/ui/mw.cx.ui.TranslationView.js
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/23/379723/1

diff --git a/modules/ui/mw.cx.ui.TranslationView.js 
b/modules/ui/mw.cx.ui.TranslationView.js
index 2d66879..2aa0e1f 100644
--- a/modules/ui/mw.cx.ui.TranslationView.js
+++ b/modules/ui/mw.cx.ui.TranslationView.js
@@ -148,6 +148,7 @@
        } );
        this.publishButton = publishButton;
        this.getToolbar().$actions.append( this.publishButton.$element );
+       this.getToolbar().initialize();
 };
 
 mw.cx.ui.TranslationView.prototype.unbindHandlers = function () {
@@ -273,10 +274,7 @@
 };
 
 mw.cx.ui.TranslationView.prototype.attachToolbar = function () {
-       var toolbar = this.getToolbar();
-       this.header.$toolbar.append( toolbar.$element );
-       toolbar.initialize();
-       this.getActions().initialize();
+       this.header.$toolbar.append( this.getToolbar().$element );
 };
 
 mw.cx.ui.TranslationView.prototype.onDocumentTransact = function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/379723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ab2cb29220efad8c6404595871f56b9e6f675f3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to