jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/379536 )

Change subject: TextInputWidget: Reduce CSS output by enhancing unselectable 
behaviour
......................................................................


TextInputWidget: Reduce CSS output by enhancing unselectable behaviour

Removing `.oo-ui-unselectable()` mixin from icons/indicators, where it
doesn't provide any effect and reducing selector output.

Change-Id: I2bf70e98e8883e9a8d1ec9e261914249038ac36b
---
M src/styles/widgets/TextInputWidget.less
1 file changed, 2 insertions(+), 8 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  Esanders: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/src/styles/widgets/TextInputWidget.less 
b/src/styles/widgets/TextInputWidget.less
index 1b60524..0734dc3 100644
--- a/src/styles/widgets/TextInputWidget.less
+++ b/src/styles/widgets/TextInputWidget.less
@@ -59,8 +59,6 @@
                position: absolute;
                top: 0;
                height: 100%;
-
-               .oo-ui-unselectable();
        }
 
        &.oo-ui-widget-enabled {
@@ -76,12 +74,8 @@
                }
        }
 
-       &.oo-ui-widget-disabled {
-               input,
-               textarea,
-               & .oo-ui-labelElement-label {
-                       .oo-ui-unselectable();
-               }
+       &.oo-ui-widget-disabled > * {
+               .oo-ui-unselectable();
        }
 
        &.oo-ui-labelElement > .oo-ui-labelElement-label {

-- 
To view, visit https://gerrit.wikimedia.org/r/379536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2bf70e98e8883e9a8d1ec9e261914249038ac36b
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to