Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/380332 )

Change subject: Improve some parameter docs
......................................................................

Improve some parameter docs

Change-Id: I6a7865d3b74617ed91a9139fd158dc43e1fcd532
---
M TemplateSandbox.hooks.php
M phpcs.xml
2 files changed, 5 insertions(+), 9 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateSandbox 
refs/changes/32/380332/1

diff --git a/TemplateSandbox.hooks.php b/TemplateSandbox.hooks.php
index 684b4d0..b0cb4fb 100644
--- a/TemplateSandbox.hooks.php
+++ b/TemplateSandbox.hooks.php
@@ -45,9 +45,9 @@
         * when our button was clicked.
         *
         * @param EditPage $editpage
-        * @param Content $content
-        * @param string $out
-        * @param ParserOutput $parserOutput
+        * @param Content &$content
+        * @param string &$out
+        * @param ParserOutput &$parserOutput
         * @return bool
         */
        public static function templateSandboxPreview( EditPage $editpage, 
&$content, &$out,
@@ -181,7 +181,7 @@
         *
         * @param EditPage $editpage
         * @param OutputPage $output
-        * @param int $tabindex
+        * @param int &$tabindex
         * @return bool
         */
        public static function injectOptions( $editpage, $output, &$tabindex ) {
@@ -313,7 +313,7 @@
         * modules.
         *
         * @param ApiBase $module
-        * @param array $params
+        * @param array &$params
         * @param int $flags
         * @return bool
         */
diff --git a/phpcs.xml b/phpcs.xml
index 7fa91dc..9a46950 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -4,14 +4,10 @@
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
                <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
                <exclude 
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment"/>
        </rule>
        <file>.</file>
        <arg name="extensions" value="php,php5,inc"/>
        <arg name="encoding" value="UTF-8"/>
-       <exclude-pattern>vendor</exclude-pattern>
-       <exclude-pattern>node_modules</exclude-pattern>
 </ruleset>

-- 
To view, visit https://gerrit.wikimedia.org/r/380332
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a7865d3b74617ed91a9139fd158dc43e1fcd532
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateSandbox
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to