jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/380088 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 13.0.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 13.0.0
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
Change-Id: Ibbbb1cb8721e4a471936dea0e2b1be57bde293ca
---
M composer.json
M phpcs.xml
M tests/phpunit/WorkflowTest.php
3 files changed, 2 insertions(+), 5 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/composer.json b/composer.json
index 9ae4d85..f0c17cb 100644
--- a/composer.json
+++ b/composer.json
@@ -8,7 +8,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
- "mediawiki/mediawiki-codesniffer": "0.12.0"
+ "mediawiki/mediawiki-codesniffer": "13.0.0"
},
"scripts": {
"fix": "phpcbf",
diff --git a/phpcs.xml b/phpcs.xml
index dc070b6..9b2d579 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,9 +1,7 @@
<?xml version="1.0"?>
<ruleset name="MediaWiki">
<file>.</file>
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
- <exclude name
="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- </rule>
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
<arg name="encoding" value="utf8" />
<arg name="colors" />
</ruleset>
diff --git a/tests/phpunit/WorkflowTest.php b/tests/phpunit/WorkflowTest.php
index 9359766..9c79f19 100644
--- a/tests/phpunit/WorkflowTest.php
+++ b/tests/phpunit/WorkflowTest.php
@@ -5,7 +5,6 @@
use Article;
use ArticleCreationWorkflow\Workflow;
use DerivativeContext;
-use EditPage;
use HashConfig;
use MediaWikiTestCase;
use RequestContext;
--
To view, visit https://gerrit.wikimedia.org/r/380088
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbbb1cb8721e4a471936dea0e2b1be57bde293ca
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader <tools.libraryupgra...@tools.wmflabs.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
