Faidon Liambotis has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/380574 )
Change subject: interface::offload: remove hardcoded default eth0
......................................................................
interface::offload: remove hardcoded default eth0
Commit 5534ed3 reinstated the previously removed interface::offload,
which at the time of its removal was hardcoding "eth0" as the default
value to $interface. We've since removed this assumption, as part of the
work to support predictable interface names. Update ::offload to remove
that hardcoded default and match the others.
Change-Id: Ica357ed6e51ec2789f66aca4859a550c5d518f88
---
M modules/interface/manifests/offload.pp
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Faidon Liambotis: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/interface/manifests/offload.pp
b/modules/interface/manifests/offload.pp
index 67320eb..8ae644a 100644
--- a/modules/interface/manifests/offload.pp
+++ b/modules/interface/manifests/offload.pp
@@ -9,9 +9,13 @@
# The (abbreviated) offload setting, e.g. 'gro'
# - $value:
# The value (on/off)
-define interface::offload($setting, $value, $interface='eth0') {
+define interface::offload($interface, $setting, $value) {
# Set in /etc/network/interfaces
- interface::setting { $title: interface => $interface, setting =>
"offload-${setting}", value => $value }
+ interface::setting { $name:
+ interface => $interface,
+ setting => "offload-${setting}",
+ value => $value,
+ }
# And make sure it's always active
$long_param = $setting ? {
--
To view, visit https://gerrit.wikimedia.org/r/380574
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica357ed6e51ec2789f66aca4859a550c5d518f88
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
