Catrope has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380683 )
Change subject: Fix rendering of unknown errors
......................................................................
Fix rendering of unknown errors
Unknown errors in the publishing process caused JS errors because
this.showErrorUnknown() was called, but the method was named
saveErrorUnknown. Rename it to "show" for consistency with
the rest of the class.
Also fix the name of the event in the doc comment.
Change-Id: Idbb9f95b68defbc0f6b501aad3bb65f9b842c920
---
M modules/mw.cx.TargetArticle.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/83/380683/1
diff --git a/modules/mw.cx.TargetArticle.js b/modules/mw.cx.TargetArticle.js
index 7d65135..b188f7a 100644
--- a/modules/mw.cx.TargetArticle.js
+++ b/modules/mw.cx.TargetArticle.js
@@ -277,9 +277,9 @@
* @method
* @param {Object} editResult
* @param {Object|null} data API response data
- * @fires saveErrorUnknown
+ * @fires publishErrorUnknown
*/
-mw.cx.TargetArticle.prototype.saveErrorUnknown = function ( editResult, data )
{
+mw.cx.TargetArticle.prototype.showErrorUnknown = function ( editResult, data )
{
var errorMsg = ( editResult && editResult.info ) || ( data &&
data.error && data.error.info ),
errorCode = ( editResult && editResult.code ) || ( data &&
data.error && data.error.code ),
unknown = 'Unknown error';
--
To view, visit https://gerrit.wikimedia.org/r/380683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbb9f95b68defbc0f6b501aad3bb65f9b842c920
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Catrope <r...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
