Cicalese has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/380909 )
Change subject: Fixed jiggling on mouseout when graph is already at rest. ...................................................................... Fixed jiggling on mouseout when graph is already at rest. Change-Id: Icfd127625a836977cc977ef5dd900f4e3c7373d1 --- M resources/PhabTaskGraph.js 1 file changed, 16 insertions(+), 12 deletions(-) Approvals: Cicalese: Verified; Looks good to me, approved diff --git a/resources/PhabTaskGraph.js b/resources/PhabTaskGraph.js index c41a78c..3f975fd 100644 --- a/resources/PhabTaskGraph.js +++ b/resources/PhabTaskGraph.js @@ -146,13 +146,15 @@ } }); - var stop_tooltip = false; - var stop_drag = false; + var dragging = false; + var paused = false; node .on('mouseover', function (d) { - stop_tooltip = true; - force.stop(); + if (force.alpha()) { + force.stop(); + paused = true; + } tooltip .transition() .duration(200) @@ -165,9 +167,9 @@ node .on('mouseout', function (d) { - stop_tooltip = false; - if (!stop_drag) { + if (!dragging && paused) { force.resume(); + paused = false; } tooltip .transition() @@ -182,8 +184,11 @@ drag .on('dragstart', function (d) { d3.event.sourceEvent.stopPropagation(); - stop_drag = true; - force.stop(); + dragging = true; + if (force.alpha()) { + force.stop(); + paused = true; + } }); drag @@ -201,10 +206,9 @@ d.fixed = !d.fixed; } tick(); - stop_drag = false; - if (!stop_tooltip) { - force.resume(); - } + dragging = false; + force.resume(); + paused = false; }); node -- To view, visit https://gerrit.wikimedia.org/r/380909 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfd127625a836977cc977ef5dd900f4e3c7373d1 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/PhabTaskGraph Gerrit-Branch: master Gerrit-Owner: Cicalese <cin...@gmail.com> Gerrit-Reviewer: Cicalese <cin...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits