jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/380492 )
Change subject: Replaced private variable and method definitions in new data reader with protected ...................................................................... Replaced private variable and method definitions in new data reader with protected Change-Id: I191bbc9fff157ff27b386e754356a98a328848f6 --- M src/Data/Reader.php M src/Data/ReaderParams.php 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Robert Vogel: Looks good to me, approved jenkins-bot: Verified diff --git a/src/Data/Reader.php b/src/Data/Reader.php index 05621d2..6afc5f3 100644 --- a/src/Data/Reader.php +++ b/src/Data/Reader.php @@ -10,7 +10,7 @@ * * @var \IContextSource */ - private $context = null; + protected $context = null; /** * diff --git a/src/Data/ReaderParams.php b/src/Data/ReaderParams.php index 5265c78..b7390ab 100644 --- a/src/Data/ReaderParams.php +++ b/src/Data/ReaderParams.php @@ -49,7 +49,7 @@ $this->setFilter( $params ); } - private function setIfAvailable( &$property, $source, $field ) { + protected function setIfAvailable( &$property, $source, $field ) { if( isset( $source[$field] ) ) { $property = $source[$field]; } -- To view, visit https://gerrit.wikimedia.org/r/380492 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I191bbc9fff157ff27b386e754356a98a328848f6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation Gerrit-Branch: master Gerrit-Owner: Pwirth <wi...@hallowelt.biz> Gerrit-Reviewer: Ljonka <l.verhovs...@gmail.com> Gerrit-Reviewer: Mglaser <gla...@hallowelt.biz> Gerrit-Reviewer: Robert Vogel <vo...@hallowelt.biz> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits