Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380934 )
Change subject: Add missing class level documentation comment blocks ...................................................................... Add missing class level documentation comment blocks See https://github.com/wmde/WikibaseCodeSniffer/pull/7 I'm not adding Jakob's as well as Aleksey's names, because I can not find their names in *any* code. It looks like they do not want to be mentioned by name. If they want, we can resolve this in later patches. Change-Id: I9dc28c297c015584b054822279862e0ff7ae6b84 --- M client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php M data-access/tests/phpunit/DataAccessSettingsTest.php M lib/includes/Store/DispatchingPropertyInfoLookup.php M repo/includes/Specials/HTMLForm/HTMLTrimmedTextField.php M repo/maintenance/SPARQLException.php M repo/tests/phpunit/includes/ChangeOp/Deserialization/ChangeOpDeserializationAssert.php M repo/tests/phpunit/includes/NewStatement.php M repo/tests/phpunit/maintenance/MockAddUnits.php 8 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/34/380934/1 diff --git a/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php b/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php index f8e41ab..fd0065c 100644 --- a/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php +++ b/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php @@ -14,6 +14,10 @@ use Wikibase\Test\MockClientStore; if ( !class_exists( Scribunto_LuaEngineTestBase::class ) ) { + /** + * @license GPL-2.0+ + * @author Marius Hoch < [email protected] > + */ abstract class Scribunto_LuaWikibaseLibraryTestCase extends PHPUnit_Framework_TestCase { protected function setUp() { diff --git a/data-access/tests/phpunit/DataAccessSettingsTest.php b/data-access/tests/phpunit/DataAccessSettingsTest.php index 709557d..d48f28b 100644 --- a/data-access/tests/phpunit/DataAccessSettingsTest.php +++ b/data-access/tests/phpunit/DataAccessSettingsTest.php @@ -4,6 +4,11 @@ use Wikibase\DataAccess\DataAccessSettings; +/** + * @covers Wikibase\DataAccess\DataAccessSettings + * + * @license GPL-2.0+ + */ class DataAccessSettingsTest extends \PHPUnit_Framework_TestCase { public function testConvertsMaxSerializedEntitySizeFromKiloBytesToBytes() { diff --git a/lib/includes/Store/DispatchingPropertyInfoLookup.php b/lib/includes/Store/DispatchingPropertyInfoLookup.php index 124ff60..802d3d3 100644 --- a/lib/includes/Store/DispatchingPropertyInfoLookup.php +++ b/lib/includes/Store/DispatchingPropertyInfoLookup.php @@ -7,6 +7,9 @@ use Wikimedia\Assert\Assert; use Wikimedia\Rdbms\DBError; +/** + * @license GPL-2.0+ + */ class DispatchingPropertyInfoLookup implements PropertyInfoLookup { /** diff --git a/repo/includes/Specials/HTMLForm/HTMLTrimmedTextField.php b/repo/includes/Specials/HTMLForm/HTMLTrimmedTextField.php index 46dd6c1..6e56935 100644 --- a/repo/includes/Specials/HTMLForm/HTMLTrimmedTextField.php +++ b/repo/includes/Specials/HTMLForm/HTMLTrimmedTextField.php @@ -5,6 +5,9 @@ use HTMLTextField; use Wikibase\StringNormalizer; +/** + * @license GPL-2.0+ + */ class HTMLTrimmedTextField extends HTMLTextField { /** diff --git a/repo/maintenance/SPARQLException.php b/repo/maintenance/SPARQLException.php index 59589f8..1f10566 100644 --- a/repo/maintenance/SPARQLException.php +++ b/repo/maintenance/SPARQLException.php @@ -4,5 +4,9 @@ use Exception; +/** + * @license GPL-2.0+ + * @author Stas Malyshev + */ class SPARQLException extends Exception { } diff --git a/repo/tests/phpunit/includes/ChangeOp/Deserialization/ChangeOpDeserializationAssert.php b/repo/tests/phpunit/includes/ChangeOp/Deserialization/ChangeOpDeserializationAssert.php index a7b0051..5262f7e 100644 --- a/repo/tests/phpunit/includes/ChangeOp/Deserialization/ChangeOpDeserializationAssert.php +++ b/repo/tests/phpunit/includes/ChangeOp/Deserialization/ChangeOpDeserializationAssert.php @@ -6,6 +6,9 @@ use PHPUnit_Framework_Assert as Assert; use Wikibase\Repo\ChangeOp\Deserialization\ChangeOpDeserializationException; +/** + * @license GPL-2.0+ + */ class ChangeOpDeserializationAssert { /** diff --git a/repo/tests/phpunit/includes/NewStatement.php b/repo/tests/phpunit/includes/NewStatement.php index 521cf23..32b35f7 100644 --- a/repo/tests/phpunit/includes/NewStatement.php +++ b/repo/tests/phpunit/includes/NewStatement.php @@ -14,6 +14,9 @@ use Wikibase\DataModel\Snak\Snak; use Wikibase\DataModel\Statement\Statement; +/** + * @license GPL-2.0+ + */ class NewStatement { const GENERATE_GUID = true; diff --git a/repo/tests/phpunit/maintenance/MockAddUnits.php b/repo/tests/phpunit/maintenance/MockAddUnits.php index 50f4624..919f7a8 100644 --- a/repo/tests/phpunit/maintenance/MockAddUnits.php +++ b/repo/tests/phpunit/maintenance/MockAddUnits.php @@ -6,6 +6,10 @@ use Wikibase\Lib\Units\UnitConverter; use Wikibase\Repo\Maintenance\SPARQLClient; +/** + * @license GPL-2.0+ + * @author Stas Malyshev + */ class MockAddUnits extends AddUnitConversions { /** -- To view, visit https://gerrit.wikimedia.org/r/380934 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9dc28c297c015584b054822279862e0ff7ae6b84 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
