jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/381047 )
Change subject: BannerHistoryLogger: Fix ajax options for when sendBeacon is
not available
......................................................................
BannerHistoryLogger: Fix ajax options for when sendBeacon is not available
Bug: T174719
Change-Id: Ifd7ab8768492584d72d954f19dc8a46d40e29f45
(cherry picked from commit b8020da6ed68b2a01a9a1785ed502a44e020ff4b)
---
M resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
AndyRussG: Looks good to me, approved
diff --git a/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
b/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
index 55866f9..636a019 100644
--- a/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
+++ b/resources/subscribing/ext.centralNotice.bannerHistoryLogger.js
@@ -225,7 +225,8 @@
elPromise = $.ajax( {
url: makeEventLoggingURL( elData ),
timeout: waitLogNoSendBeacon,
- method: 'POST'
+ dataType: 'script', // Helps prevent CORS
issues? See T174719
+ cache: true // Prevent JQuery from adding a
timestamp to the URL
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/381047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd7ab8768492584d72d954f19dc8a46d40e29f45
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: wmf_deploy
Gerrit-Owner: AndyRussG <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
