Nikerabbit has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381528 )
Change subject: Fix editor shortcuts not showing up
......................................................................
Fix editor shortcuts not showing up
JQMIGRATE: jQuery.fn.offset() requires an element connected to a document
Uncaught TypeError: $(...).text(...).offset(...).addClass is not a function
The position of those shortcuts is off, but that seems to be caused by the
jQuery Migrate plugin.
Change-Id: If7618ef0e82c7116f7acccf272ca604d0df4e834
---
M resources/js/ext.translate.editor.shortcuts.js
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/28/381528/1
diff --git a/resources/js/ext.translate.editor.shortcuts.js
b/resources/js/ext.translate.editor.shortcuts.js
index 989e689..6b77019 100644
--- a/resources/js/ext.translate.editor.shortcuts.js
+++ b/resources/js/ext.translate.editor.shortcuts.js
@@ -27,14 +27,14 @@
$( '<div>' )
.text( '↑' )
.offset( { top: middle - 10, left: maxLeft } )
- .addClass( 'shortcut-popup' )
- .appendTo( 'body' );
+ .appendTo( 'body' )
+ .addClass( 'shortcut-popup' );
$( '<div>' )
.text( '↓' )
.offset( { top: middle + 10, left: maxLeft } )
- .addClass( 'shortcut-popup' )
- .appendTo( 'body' );
+ .appendTo( 'body' )
+ .addClass( 'shortcut-popup' );
this.$editor.find( '.shortcut-activated:visible'
).each( function ( index ) {
var $this = $( this ),
@@ -52,8 +52,8 @@
$( '<div>' )
.text( index + 1 )
.offset( offset )
- .addClass( 'shortcut-popup' )
- .appendTo( 'body' );
+ .appendTo( 'body' )
+ .addClass( 'shortcut-popup' );
} );
},
--
To view, visit https://gerrit.wikimedia.org/r/381528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7618ef0e82c7116f7acccf272ca604d0df4e834
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
