jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378079 )
Change subject: Check requirements for parser test suite in phpunit tests
......................................................................
Check requirements for parser test suite in phpunit tests
There was a different between parserTests.php and phpunit.php
for parser tests,
missing hooks are failing on phpunit, not skipping
Fixed that
Change-Id: If6cdab2ec793895db566d9389edc1444a4fe25b0
---
M tests/phpunit/suites/ParserTestFileSuite.php
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, but someone else must approve
diff --git a/tests/phpunit/suites/ParserTestFileSuite.php
b/tests/phpunit/suites/ParserTestFileSuite.php
index dbee894..b72d8b8 100644
--- a/tests/phpunit/suites/ParserTestFileSuite.php
+++ b/tests/phpunit/suites/ParserTestFileSuite.php
@@ -23,6 +23,10 @@
}
function setUp() {
- $this->ptRunner->addArticles( $this->ptFileInfo[ 'articles'] );
+ if ( !$this->ptRunner->meetsRequirements(
$this->ptFileInfo['requirements'] ) ) {
+ $this->markTestSuiteSkipped( 'required extension not
enabled' );
+ } else {
+ $this->ptRunner->addArticles( $this->ptFileInfo[
'articles'] );
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/378079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6cdab2ec793895db566d9389edc1444a4fe25b0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: C. Scott Ananian <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
