jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/381532 )
Change subject: mw.loader: Return consistent object shape from splitModuleKey()
......................................................................
mw.loader: Return consistent object shape from splitModuleKey()
This is used in mw.loader.implement() in a truthy check before
assigning as value of `registry[module].version`.
Both implicit undefined and empty string are falsey so the
behaviour is unchanged.
This reduces shape variability for JS engines, and also avoid
potential mistakes if the function is used elsewhere since
internally the registry, as maintained by mw.loader.register(),
uses empty string as default for version, not undefined.
Change-Id: I067137557a55d521fefa40986373e55b6bbb59ff
---
M resources/src/mediawiki/mediawiki.js
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, but someone else must approve
diff --git a/resources/src/mediawiki/mediawiki.js
b/resources/src/mediawiki/mediawiki.js
index aae292d..66e09dc 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -1718,7 +1718,10 @@
function splitModuleKey( key ) {
var index = key.indexOf( '@' );
if ( index === -1 ) {
- return { name: key };
+ return {
+ name: key,
+ version: ''
+ };
}
return {
name: key.slice( 0, index ),
--
To view, visit https://gerrit.wikimedia.org/r/381532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I067137557a55d521fefa40986373e55b6bbb59ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
