Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381759 )
Change subject: Exclude failing sniff
......................................................................
Exclude failing sniff
FILE: EducationProgram\includes\rows\Org.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
92 | WARNING | Should use function $this->msg() rather than function
| | wfMessage() .
| | (MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage)
97 | WARNING | Should use function $this->msg() rather than function
| | wfMessage() .
| | (MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage)
----------------------------------------------------------------------
No idea why tests not failing
Change-Id: I035e6384728ee31d4d48abe45c57860231d1d3e1
---
M phpcs.xml
1 file changed, 1 insertion(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram
refs/changes/59/381759/1
diff --git a/phpcs.xml b/phpcs.xml
index eca099d..2b8d3f2 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -14,6 +14,7 @@
<exclude name="MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals"
/>
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
<exclude
name="Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed" />
+ <exclude
name="MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage" />
</rule>
<rule ref="MediaWiki.NamingConventions.ValidGlobalName">
<properties>
--
To view, visit https://gerrit.wikimedia.org/r/381759
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I035e6384728ee31d4d48abe45c57860231d1d3e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
