Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/381914 )
Change subject: Chore: rename Namespace to PageNamespace
......................................................................
Chore: rename Namespace to PageNamespace
Rename Namespace to PageNamespace for consistency with the other page
models.
Change-Id: Iefa8896faec9d879187ca2c01f15a849916d55fd
---
M src/common/models/page/namespace.test.ts
M src/common/models/page/namespace.ts
2 files changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/14/381914/1
diff --git a/src/common/models/page/namespace.test.ts
b/src/common/models/page/namespace.test.ts
index d8863c3..275fa3f 100644
--- a/src/common/models/page/namespace.test.ts
+++ b/src/common/models/page/namespace.test.ts
@@ -1,25 +1,25 @@
import * as assert from "assert";
-import { Namespace, special, main, talk, file } from "./namespace";
+import { PageNamespace, special, main, talk, file } from "./namespace";
describe("namespace", () => {
describe(`.special()`, () => {
- it(`is special`, () => assert.ok(special(Namespace.SPECIAL)));
- it(`not special`, () => assert.ok(!special(Namespace.MAIN)));
+ it(`is special`, () => assert.ok(special(PageNamespace.SPECIAL)));
+ it(`not special`, () => assert.ok(!special(PageNamespace.MAIN)));
});
describe(`.main()`, () => {
- it(`is main`, () => assert.ok(main(Namespace.MAIN)));
- it(`not main`, () => assert.ok(!main(Namespace.TALK)));
+ it(`is main`, () => assert.ok(main(PageNamespace.MAIN)));
+ it(`not main`, () => assert.ok(!main(PageNamespace.TALK)));
});
describe(`.talk()`, () => {
- it(`is talk`, () => assert.ok(talk(Namespace.TALK)));
- it(`not talk`, () => assert.ok(!talk(Namespace.MAIN)));
- it(`special is not talk`, () => assert.ok(!talk(Namespace.SPECIAL)));
+ it(`is talk`, () => assert.ok(talk(PageNamespace.TALK)));
+ it(`not talk`, () => assert.ok(!talk(PageNamespace.MAIN)));
+ it(`special is not talk`, () => assert.ok(!talk(PageNamespace.SPECIAL)));
});
describe(`.file()`, () => {
- it(`is file`, () => assert.ok(file(Namespace.FILE)));
- it(`not file`, () => assert.ok(!file(Namespace.MAIN)));
+ it(`is file`, () => assert.ok(file(PageNamespace.FILE)));
+ it(`not file`, () => assert.ok(!file(PageNamespace.MAIN)));
});
});
diff --git a/src/common/models/page/namespace.ts
b/src/common/models/page/namespace.ts
index 18b65be..772175c 100644
--- a/src/common/models/page/namespace.ts
+++ b/src/common/models/page/namespace.ts
@@ -11,7 +11,7 @@
* @see {@link
https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces
Manual:Namespace}
* @see {@link
https://en.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=namespaces|namespacealiases
Namespaces reported by API}
*/
-export enum Namespace {
+export enum PageNamespace {
MEDIA = -2,
SPECIAL = -1, // The only namespace where a bitwise test of TALK_MASK fails.
/** Main page, disambiguation page, or article. */
@@ -33,15 +33,15 @@
CATEGORY_TALK = 15
}
-export const special = (namespace: Namespace): boolean =>
- namespace === Namespace.SPECIAL;
+export const special = (namespace: PageNamespace): boolean =>
+ namespace === PageNamespace.SPECIAL;
-export const main = (namespace: Namespace): boolean =>
- namespace === Namespace.MAIN;
+export const main = (namespace: PageNamespace): boolean =>
+ namespace === PageNamespace.MAIN;
-export const talk = (namespace: Namespace): boolean =>
+export const talk = (namespace: PageNamespace): boolean =>
// eslint-disable-next-line no-bitwise
(namespace & TALK_MASK) === TALK_MASK && !special(namespace);
-export const file = (namespace: Namespace): boolean =>
- namespace === Namespace.FILE;
+export const file = (namespace: PageNamespace): boolean =>
+ namespace === PageNamespace.FILE;
--
To view, visit https://gerrit.wikimedia.org/r/381914
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefa8896faec9d879187ca2c01f15a849916d55fd
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
