Hello Tim Starling, Krinkle, Greg Grossmeier, Rammanojpotla, jenkins-bot,
Jdlrobson, Mooeypoo,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/382020
to review the following change.
Change subject: Revert "Fix reversed nav elements when viewing cached HTML"
......................................................................
Revert "Fix reversed nav elements when viewing cached HTML"
No longer needed for Wikimedia wikis after the HTML caches expired.
This reverts commit e951a09913c718ba894c581a4598b6976a92c3b9.
Change-Id: I5eda153e3368f6a7f9d2f88e336e02b65d01f2b5
---
M SkinVector.php
M components/personalMenu.less
M components/tabs.less
3 files changed, 0 insertions(+), 38 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector
refs/changes/20/382020/1
diff --git a/SkinVector.php b/SkinVector.php
index 23dd944..f684891 100644
--- a/SkinVector.php
+++ b/SkinVector.php
@@ -47,7 +47,6 @@
if ( $this->vectorConfig->get( 'VectorExperimentalPrintStyles'
) ) {
$className .= ' vector-experimental-print-styles';
}
- $className .= ' vector-nav-directionality';
return $className;
}
diff --git a/components/personalMenu.less b/components/personalMenu.less
index a91b7b3..979831f 100644
--- a/components/personalMenu.less
+++ b/components/personalMenu.less
@@ -19,16 +19,11 @@
li {
line-height: 1.125em;
- /* @noflip */
float: left;
margin-left: 0.75em;
margin-top: 0.5em;
font-size: @menu-personal-font-size;
white-space: nowrap;
-
- .vector-nav-directionality & {
- float: left;
- }
}
}
diff --git a/components/tabs.less b/components/tabs.less
index 1b78203..211d1fd 100644
--- a/components/tabs.less
+++ b/components/tabs.less
@@ -9,7 +9,6 @@
/* Namespaces and Views */
div.vectorTabs {
- /* @noflip */
float: left;
height: 2.5em;
.background-image('images/tab-break.png');
@@ -17,12 +16,7 @@
background-repeat: no-repeat;
padding-left: 1px;
- .vector-nav-directionality & {
- float: left;
- }
-
ul {
- /* @noflip */
float: left;
height: 100%;
list-style-type: none;
@@ -33,12 +27,7 @@
background-position: right bottom;
background-repeat: no-repeat;
- .vector-nav-directionality & {
- float: left;
- }
-
li {
- /* @noflip */
float: left;
line-height: 1.125em;
/* For IE6, overridden later to display:block by modern
browsers */
@@ -51,10 +40,6 @@
background-position: bottom left;
background-repeat: repeat-x;
white-space: nowrap;
-
- .vector-nav-directionality & {
- float: left;
- }
}
/* IGNORED BY IE6 which doesn't support child selector */
@@ -119,31 +104,19 @@
/* Ignored by IE6 which doesn't support child selector */
> a {
- /* @noflip */
float: left;
display: block;
-
- .vector-nav-directionality & {
- float: left;
- }
}
}
}
/* Variants and Actions */
div.vectorMenu {
- /* @noflip */
direction: ltr;
- /* @noflip */
float: left;
cursor: pointer;
position: relative;
line-height: 1.125em;
-
- .vector-nav-directionality & {
- direction: ltr;
- float: left;
- }
}
body.rtl div.vectorMenu {
@@ -152,7 +125,6 @@
}
div#mw-head div.vectorMenu h3 {
- /* @noflip */
float: left;
.background-image('images/tab-break.png');
background-repeat: no-repeat;
@@ -163,10 +135,6 @@
// border. It is necessary for the dropdown (div.vectorMenu div.menu)
to align well.
padding-right: 1px;
margin-right: -1px;
-
- .vector-nav-directionality & {
- float: left;
- }
}
div.vectorMenu h3 span {
--
To view, visit https://gerrit.wikimedia.org/r/382020
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5eda153e3368f6a7f9d2f88e336e02b65d01f2b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Greg Grossmeier <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: Rammanojpotla <[email protected]>
Gerrit-Reviewer: Tim Starling <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
