Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382025 )
Change subject: Fix applying of focus styles to .vectorMenu handle
......................................................................
Fix applying of focus styles to .vectorMenu handle
The .vectorMenuFocus class was being added on the wrong element, so
the styles for it never kicked in. I think this has been broken since
4fabc910d2e1bb4581ac7a80f019bd22758d089b (August 2013), which is
understandable since the style change is near impossible to notice
(the little triangle arrow turns a slightly lighter shade of grey).
Change-Id: I0f7881afde9e01061aacf009033255774d0acd8d
---
M vector.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector
refs/changes/25/382025/1
diff --git a/vector.js b/vector.js
index 9d4c48a..e26cbc9 100644
--- a/vector.js
+++ b/vector.js
@@ -41,10 +41,10 @@
} )
// When the heading has focus, also set a class that
will change the arrow icon
.focus( function () {
- $el.find( '> span' ).addClass(
'vectorMenuFocus' );
+ $el.addClass( 'vectorMenuFocus' );
} )
.blur( function () {
- $el.find( '> span' ).removeClass(
'vectorMenuFocus' );
+ $el.removeClass( 'vectorMenuFocus' );
} );
} );
--
To view, visit https://gerrit.wikimedia.org/r/382025
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f7881afde9e01061aacf009033255774d0acd8d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
