Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382238 )
Change subject: Correct feature phone threshold detection
......................................................................
Correct feature phone threshold detection
max-width should actually be one smaller than the threshold
Additional changes:
* Also rename to @width-breakpoint-mobile and
rename @width-breakpoint-desktop for desktop variable in
anticipation of T171365
Bug: T176286
Change-Id: Ia37bceb46a6b780f473828ff38749543bdfcc9f6
---
M minerva.less/minerva.variables.less
M resources/skins.minerva.base.styles/pageactions.less
M resources/skins.minerva.content.styles/main.less
M resources/skins.minerva.tablet.styles/common.less
M skinStyles/mobile.languages.structured/LanguageOverlay.less
M skinStyles/mobile.pointerOverlay/minerva.less
M skinStyles/mobile.search/SearchOverlay.less
M skinStyles/mobile.startup/Overlay.less
8 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue
refs/changes/38/382238/1
diff --git a/minerva.less/minerva.variables.less
b/minerva.less/minerva.variables.less
index 754b58d..c27aee6 100644
--- a/minerva.less/minerva.variables.less
+++ b/minerva.less/minerva.variables.less
@@ -15,8 +15,8 @@
@grayLight: @colorGray12;
@grayLightest: @colorGray14;
-@wgMFDeviceWidthMobileSmall: 320px;
-@wgMFDeviceWidthDesktop: 1000px;
+@width-breakpoint-mobile: 320px;
+@width-breakpoint-desktop: 1000px;
@skinContentBgColor: #fff;
@@ -85,7 +85,7 @@
@contentPaddingTablet: 3.35em;
// note since content does not use view border box we have to include padding.
-@contentMaxWidthTablet: @wgMFDeviceWidthDesktop - ( 2 * @contentPaddingTablet
);
+@contentMaxWidthTablet: @width-breakpoint-desktop - ( 2 *
@contentPaddingTablet );
@contentTopPadding: 1.6em;
// Wiki specific variables
diff --git a/resources/skins.minerva.base.styles/pageactions.less
b/resources/skins.minerva.base.styles/pageactions.less
index 2e96bd9..0742202 100644
--- a/resources/skins.minerva.base.styles/pageactions.less
+++ b/resources/skins.minerva.base.styles/pageactions.less
@@ -112,7 +112,7 @@
}
// On small devices that don't support Javascript, hide the page actions bar
-@media all and ( max-width: @wgMFDeviceWidthMobileSmall ) {
+@media all and ( max-width: @width-breakpoint-mobile - 1 ) {
.client-nojs {
#page-actions {
display: none;
diff --git a/resources/skins.minerva.content.styles/main.less
b/resources/skins.minerva.content.styles/main.less
index dc12d75..7e4b982 100644
--- a/resources/skins.minerva.content.styles/main.less
+++ b/resources/skins.minerva.content.styles/main.less
@@ -28,7 +28,7 @@
word-wrap: break-word;
}
-@media all and ( max-width: @wgMFDeviceWidthMobileSmall ) {
+@media all and ( max-width: @width-breakpoint-mobile - 1 ) {
body {
font-size: 0.8em;
}
diff --git a/resources/skins.minerva.tablet.styles/common.less
b/resources/skins.minerva.tablet.styles/common.less
index e5f4e6d..ba87302 100644
--- a/resources/skins.minerva.tablet.styles/common.less
+++ b/resources/skins.minerva.tablet.styles/common.less
@@ -119,7 +119,7 @@
}
}
-@media screen and ( min-width: @wgMFDeviceWidthDesktop ) {
+@media screen and ( min-width: @width-breakpoint-desktop ) {
// FIXME: Zero should use banner-container class or better - append to
banner-container
#mw-mf-page-center .mw-mf-banner,
.banner-container,
diff --git a/skinStyles/mobile.languages.structured/LanguageOverlay.less
b/skinStyles/mobile.languages.structured/LanguageOverlay.less
index f1fd903..6e96b07 100644
--- a/skinStyles/mobile.languages.structured/LanguageOverlay.less
+++ b/skinStyles/mobile.languages.structured/LanguageOverlay.less
@@ -1,6 +1,6 @@
@import 'minerva.variables';
-@media screen and ( min-width: @wgMFDeviceWidthDesktop ) {
+@media screen and ( min-width: @width-breakpoint-desktop ) {
.language-overlay {
.overlay-content {
margin: 0;
diff --git a/skinStyles/mobile.pointerOverlay/minerva.less
b/skinStyles/mobile.pointerOverlay/minerva.less
index 9f1b5b0..47bea85 100644
--- a/skinStyles/mobile.pointerOverlay/minerva.less
+++ b/skinStyles/mobile.pointerOverlay/minerva.less
@@ -7,7 +7,7 @@
// can point to anything in the containing content area and avoid
// padding issues such as https://phabricator.wikimedia.org/F287611
#mw-mf-page-center .pointer-overlay {
- max-width: @wgMFDeviceWidthDesktop;
+ max-width: @width-breakpoint-desktop;
}
}
diff --git a/skinStyles/mobile.search/SearchOverlay.less
b/skinStyles/mobile.search/SearchOverlay.less
index 8d3eb49..e0232f4 100644
--- a/skinStyles/mobile.search/SearchOverlay.less
+++ b/skinStyles/mobile.search/SearchOverlay.less
@@ -45,7 +45,7 @@
}
}
-@media all and ( min-width: @wgMFDeviceWidthDesktop ) {
+@media all and ( min-width: @width-breakpoint-desktop ) {
.search-overlay {
.overlay-content {
// align with the search form
diff --git a/skinStyles/mobile.startup/Overlay.less
b/skinStyles/mobile.startup/Overlay.less
index 5f3c641..c0b123c 100644
--- a/skinStyles/mobile.startup/Overlay.less
+++ b/skinStyles/mobile.startup/Overlay.less
@@ -24,7 +24,7 @@
}
}
-@media all and ( min-width: @wgMFDeviceWidthDesktop ) {
+@media all and ( min-width: @width-breakpoint-desktop ) {
.overlay-header {
// Make sure the close button and secondary button icon images
are aligned
// with the content.
--
To view, visit https://gerrit.wikimedia.org/r/382238
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia37bceb46a6b780f473828ff38749543bdfcc9f6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.31.0-wmf.2
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
