Chelsyx has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382320 )
Change subject: pageviews that are search results pages ...................................................................... pageviews that are search results pages In T176464#3636190, @Jdlrobson mentioned that on some browsers, when you clicked on the search icon, it will take you to a blank Special:Search page and let you start from there. Therefore, we should exclude these blank SRP from our counts. Change-Id: If4aef7521a3268da85e7a3498cce1b33a2ee43a4 --- M modules/metrics/search/search_result_pages M modules/metrics/search/sister_search_traffic 2 files changed, 10 insertions(+), 14 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/golden refs/changes/20/382320/1 diff --git a/modules/metrics/search/search_result_pages b/modules/metrics/search/search_result_pages index 348de5f..5908f4e 100755 --- a/modules/metrics/search/search_result_pages +++ b/modules/metrics/search/search_result_pages @@ -26,13 +26,11 @@ AND page_id IS NULL AND ( uri_path = '/wiki/Special:Search' - OR ( - uri_path = '/w/index.php' - AND ( - LENGTH(PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 'QUERY', 'search')) > 0 - OR LENGTH(PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 'QUERY', 'searchToken')) > 0 - ) - ) + OR uri_path = '/w/index.php' + ) + AND ( + LENGTH(PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 'QUERY', 'search')) > 0 + OR LENGTH(PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 'QUERY', 'searchToken')) > 0 ) ) AS serp GROUP BY date, access_method, agent_type; diff --git a/modules/metrics/search/sister_search_traffic b/modules/metrics/search/sister_search_traffic index 0e5b7c6..3e40bc0 100755 --- a/modules/metrics/search/sister_search_traffic +++ b/modules/metrics/search/sister_search_traffic @@ -23,13 +23,11 @@ page_id IS NULL AND ( uri_path = '/wiki/Special:Search' - OR ( - uri_path = '/w/index.php' - AND ( - PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 'QUERY', 'search') IS NOT NULL - OR PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 'QUERY', 'searchToken') IS NOT NULL - ) - ) + OR uri_path = '/w/index.php' + ) + AND ( + LENGTH(PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 'QUERY', 'search')) > 0 + OR LENGTH(PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 'QUERY', 'searchToken')) > 0 ) ) AS is_serp FROM webrequest -- To view, visit https://gerrit.wikimedia.org/r/382320 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If4aef7521a3268da85e7a3498cce1b33a2ee43a4 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/discovery/golden Gerrit-Branch: master Gerrit-Owner: Chelsyx <c...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits